Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: chrome/browser/extensions/api/developer_private/developer_private_mangle.cc

Issue 2481923002: [WIP] make GURL::path() return a StringPiece (Closed)
Patch Set: thanks asan Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/developer_private/developer_private_mang le.h" 5 #include "chrome/browser/extensions/api/developer_private/developer_private_mang le.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/values.h" 9 #include "base/values.h"
10 #include "chrome/common/extensions/api/developer_private.h" 10 #include "chrome/common/extensions/api/developer_private.h"
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 severity = logging::LOG_ERROR; 97 severity = logging::LOG_ERROR;
98 value->SetInteger("level", static_cast<int>(severity)); 98 value->SetInteger("level", static_cast<int>(severity));
99 result.runtime_errors.push_back(std::move(value)); 99 result.runtime_errors.push_back(std::move(value));
100 } 100 }
101 result.offline_enabled = info.offline_enabled; 101 result.offline_enabled = info.offline_enabled;
102 for (const api::developer_private::ExtensionView& view : info.views) { 102 for (const api::developer_private::ExtensionView& view : info.views) {
103 api::developer_private::ItemInspectView view_copy; 103 api::developer_private::ItemInspectView view_copy;
104 GURL url(view.url); 104 GURL url(view.url);
105 if (url.scheme() == kExtensionScheme) { 105 if (url.scheme() == kExtensionScheme) {
106 // No leading slash. 106 // No leading slash.
107 view_copy.path = url.path().substr(1); 107 view_copy.path = url.path().substr(1).as_string();
108 } else { 108 } else {
109 // For live pages, use the full URL. 109 // For live pages, use the full URL.
110 view_copy.path = url.spec(); 110 view_copy.path = url.spec();
111 } 111 }
112 view_copy.render_process_id = view.render_process_id; 112 view_copy.render_process_id = view.render_process_id;
113 view_copy.render_view_id = view.render_view_id; 113 view_copy.render_view_id = view.render_view_id;
114 view_copy.incognito = view.incognito; 114 view_copy.incognito = view.incognito;
115 view_copy.generated_background_page = 115 view_copy.generated_background_page =
116 view_copy.path == kGeneratedBackgroundPageFilename; 116 view_copy.path == kGeneratedBackgroundPageFilename;
117 result.views.push_back(std::move(view_copy)); 117 result.views.push_back(std::move(view_copy));
118 } 118 }
119 119
120 return result; 120 return result;
121 } 121 }
122 122
123 } // namespace developer_private_mangle 123 } // namespace developer_private_mangle
124 } // namespace extensions 124 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698