Add icu libraries to unittests dependencies

Add icu libraries to unittests dependencies

In component build, unittests did not link with icu libraries, which
caused errors. By adding icu libraries to dependencies unittests links
correctly.

BUG=
TEST=unittests/*

Committed: https://crrev.com/6f556b3394ecfc246dd197b1d5991e505cd94ca2
Cr-Commit-Position: refs/heads/master@{#40955}

[miran.karic, 2016-11-04 14:11:51]

miran.karic@imgtec.com changed reviewers:
+ jochen@chromium.org

[miran.karic, 2016-11-04 14:11:52]

PTAL. The problem started with changes in
https://codereview.chromium.org/2416243002.

[jochen (gone - plz use gerrit), 2016-11-04 14:16:22]

can you please add the dependency to the BUILD.gn file as well?

[miran.karic, 2016-11-04 14:31:27]

On 2016/11/04 14:16:22, jochen wrote:
> can you please add the dependency to the BUILD.gn file as well?

Yes, I forgot about that, done. Didn't have time to test yet so I will do that
before I land.

[jochen (gone - plz use gerrit), 2016-11-04 14:36:32]

sorry, forgot to ask this initially.

The dependency also exists in static builds, right? It's just that it won't
break if it's missing?

[miran.karic, 2016-11-04 15:02:37]

On 2016/11/04 14:36:32, jochen wrote:
> sorry, forgot to ask this initially.
> 
> The dependency also exists in static builds, right? It's just that it won't
> break if it's missing?

In static build unittests links correctly, but it seems that is because it links
v8_external_snapshot so it also links icu as dependency.

[jochen (gone - plz use gerrit), 2016-11-04 15:03:36]

yeah, I think it's cleaner to always add the depdendency on icu (if i18n is
enabled)

[miran.karic, 2016-11-07 15:47:49]

On 2016/11/04 15:03:36, jochen (travelling til Nov 18) wrote:
> yeah, I think it's cleaner to always add the depdendency on icu (if i18n is
> enabled)

Done, I had to move v8_enable_i18n_support to v8.gni so I can access it from
unittests. Now gn works as well.

[jochen (gone - plz use gerrit), 2016-11-12 20:57:12]

lgtm

[miran.karic, 2016-11-14 09:35:56]

The CQ bit was checked by miran.karic@imgtec.com

[commit-bot: I haz the power, 2016-11-14 09:36:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 10:01:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-17 22:32:04]

Description was changed from

==========
Add icu libraries to unittests dependencies

In component build, unittests did not link with icu libraries, which
caused errors. By adding icu libraries to dependencies unittests links
correctly.

BUG=
TEST=unittests/*
==========

to

==========
Add icu libraries to unittests dependencies

In component build, unittests did not link with icu libraries, which
caused errors. By adding icu libraries to dependencies unittests links
correctly.

BUG=
TEST=unittests/*

Committed: https://crrev.com/6f556b3394ecfc246dd197b1d5991e505cd94ca2
Cr-Commit-Position: refs/heads/master@{#40955}
==========

[commit-bot: I haz the power, 2016-11-17 22:32:05]

Patchset 3 (id:??) landed as
https://crrev.com/6f556b3394ecfc246dd197b1d5991e505cd94ca2
Cr-Commit-Position: refs/heads/master@{#40955}