Make unittests work in component build

Make unittests work in component build

R=machenbach@chromium.org,titzer@chromium.org,bmeurer@chromium.org,jgruber@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_win_dbg,v8_mac_dbg;master.tryserver.chromium.android:android_arm64_dbg_recipe

Committed: https://crrev.com/6755b55a74283a953038baae944a8563c2e29daa
Cr-Commit-Position: refs/heads/master@{#40350}

[jochen (gone - plz use gerrit), 2016-10-14 15:53:04]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 15:53:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-10-14 15:53:39]

Description was changed from

==========
Make unittests work in component build

R=machenbach@chromium.org,titzer@chromium.org,bmeurer@chromium.org,jgruber@ch...
BUG=
==========

to

==========
Make unittests work in component build

R=machenbach@chromium.org,titzer@chromium.org,bmeurer@chromium.org,jgruber@ch...
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_win_dbg,v8_mac_dbg;master.tryserver.chromium.android:android_arm64_dbg_recipe
==========

[jochen (gone - plz use gerrit), 2016-10-14 15:53:45]

The CQ bit was unchecked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-10-14 15:53:51]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 15:53:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 16:00:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 16:00:29]

Dry run: Try jobs failed on following builders:
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/2...)

[jochen (gone - plz use gerrit), 2016-10-14 16:40:39]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 16:40:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 16:46:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 16:46:58]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[jochen (gone - plz use gerrit), 2016-10-17 07:15:33]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 07:15:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-10-17 07:16:37]

ptal

Ben, src/asmjs and src/wasm
Benedikt, rest
Michael/Jakob, build config

[commit-bot: I haz the power, 2016-10-17 07:22:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 07:22:08]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[jochen (gone - plz use gerrit), 2016-10-17 07:50:23]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 07:50:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Achenbach, 2016-10-17 08:07:01]

Awesome, configs lgtm!

[titzer, 2016-10-17 08:11:31]

On 2016/10/17 08:07:01, machenbach (slow) wrote:
> Awesome, configs lgtm!

Is there a doc somewhere that describes when these annotations are necessary?
E.g. it appears that everything from V8 that is used in a unittest now has
annotation. That worries me a bit.

[jochen (gone - plz use gerrit), 2016-10-17 08:35:22]

On 2016/10/17 at 08:11:31, titzer wrote:
> On 2016/10/17 08:07:01, machenbach (slow) wrote:
> > Awesome, configs lgtm!
> 
> Is there a doc somewhere that describes when these annotations are necessary?
E.g. it appears that everything from V8 that is used in a unittest now has
annotation. That worries me a bit.

I've send a summary to v8-dev

What's your worry?

[Benedikt Meurer, 2016-10-17 08:40:21]

LGTM (rubber-stamped)

[titzer, 2016-10-17 08:41:52]

On 2016/10/17 08:35:22, jochen wrote:
> On 2016/10/17 at 08:11:31, titzer wrote:
> > On 2016/10/17 08:07:01, machenbach (slow) wrote:
> > > Awesome, configs lgtm!
> > 
> > Is there a doc somewhere that describes when these annotations are
necessary?
> E.g. it appears that everything from V8 that is used in a unittest now has
> annotation. That worries me a bit.
> 
> I've send a summary to v8-dev
> 
> What's your worry?

Just that I will forget these and things will slowly rot, or I won't and it will
be caught late by either an FYI builder or the CQ.

[commit-bot: I haz the power, 2016-10-17 08:42:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 08:42:13]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-10-17 09:00:08]

On 2016/10/17 at 08:41:52, titzer wrote:
> On 2016/10/17 08:35:22, jochen wrote:
> > On 2016/10/17 at 08:11:31, titzer wrote:
> > > On 2016/10/17 08:07:01, machenbach (slow) wrote:
> > > > Awesome, configs lgtm!
> > > 
> > > Is there a doc somewhere that describes when these annotations are
necessary?
> > E.g. it appears that everything from V8 that is used in a unittest now has
> > annotation. That worries me a bit.
> > 
> > I've send a summary to v8-dev
> > 
> > What's your worry?
> 
> Just that I will forget these and things will slowly rot, or I won't and it
will be caught late by either an FYI builder or the CQ.

Component build is the default for debug and optdebug, so both locally and on
the default bots you'll get errors if you forget an annotation

[titzer, 2016-10-17 09:50:37]

On 2016/10/17 09:00:08, jochen wrote:
> On 2016/10/17 at 08:41:52, titzer wrote:
> > On 2016/10/17 08:35:22, jochen wrote:
> > > On 2016/10/17 at 08:11:31, titzer wrote:
> > > > On 2016/10/17 08:07:01, machenbach (slow) wrote:
> > > > > Awesome, configs lgtm!
> > > > 
> > > > Is there a doc somewhere that describes when these annotations are
> necessary?
> > > E.g. it appears that everything from V8 that is used in a unittest now has
> > > annotation. That worries me a bit.
> > > 
> > > I've send a summary to v8-dev
> > > 
> > > What's your worry?
> > 
> > Just that I will forget these and things will slowly rot, or I won't and it
> will be caught late by either an FYI builder or the CQ.
> 
> Component build is the default for debug and optdebug, so both locally and on
> the default bots you'll get errors if you forget an annotation

Alrighty. LGTM

[jochen (gone - plz use gerrit), 2016-10-17 09:56:58]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2016-10-17 09:57:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 10:01:49]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-17 10:02:15]

Description was changed from

==========
Make unittests work in component build

R=machenbach@chromium.org,titzer@chromium.org,bmeurer@chromium.org,jgruber@ch...
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_win_dbg,v8_mac_dbg;master.tryserver.chromium.android:android_arm64_dbg_recipe
==========

to

==========
Make unittests work in component build

R=machenbach@chromium.org,titzer@chromium.org,bmeurer@chromium.org,jgruber@ch...
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_win_dbg,v8_mac_dbg;master.tryserver.chromium.android:android_arm64_dbg_recipe

Committed: https://crrev.com/6755b55a74283a953038baae944a8563c2e29daa
Cr-Commit-Position: refs/heads/master@{#40350}
==========

[commit-bot: I haz the power, 2016-10-17 10:02:16]

Patchset 4 (id:??) landed as
https://crrev.com/6755b55a74283a953038baae944a8563c2e29daa
Cr-Commit-Position: refs/heads/master@{#40350}