Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: BUILD.gn

Issue 2479863002: Add icu libraries to unittests dependencies (Closed)
Patch Set: Check only i18n flag and fix gn Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gni/v8.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 32a1417d492b231046cd497cfb7dbb991f42fdea..11329c6475e2aabf3158577af097bd2c835f4c12 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -43,10 +43,6 @@ declare_args() {
# Sets -dENABLE_HANDLE_ZAPPING.
v8_enable_handle_zapping = true
- # Enable ECMAScript Internationalization API. Enabling this feature will
- # add a dependency on the ICU library.
- v8_enable_i18n_support = true
-
# Enable slow dchecks.
v8_enable_slow_dchecks = false
« no previous file with comments | « no previous file | gni/v8.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698