Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Side by Side Diff: test/unittests/BUILD.gn

Issue 2479863002: Add icu libraries to unittests dependencies (Closed)
Patch Set: Check only i18n flag and fix gn Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gni/v8.gni ('k') | test/unittests/unittests.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The V8 project authors. All rights reserved. 1 # Copyright 2016 The V8 project authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("../../gni/v8.gni") 5 import("../../gni/v8.gni")
6 6
7 v8_executable("unittests") { 7 v8_executable("unittests") {
8 testonly = true 8 testonly = true
9 9
10 sources = [ 10 sources = [
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 deps = [ 163 deps = [
164 "../..:v8", 164 "../..:v8",
165 "../..:v8_libbase", 165 "../..:v8_libbase",
166 "../..:v8_libplatform", 166 "../..:v8_libplatform",
167 "//build/config/sanitizers:deps", 167 "//build/config/sanitizers:deps",
168 "//build/win:default_exe_manifest", 168 "//build/win:default_exe_manifest",
169 "//testing/gmock", 169 "//testing/gmock",
170 "//testing/gtest", 170 "//testing/gtest",
171 ] 171 ]
172 172
173 if (v8_enable_i18n_support) {
174 deps += [ "//third_party/icu" ]
175 }
176
173 if (is_win) { 177 if (is_win) {
174 # This warning is benignly triggered by the U16 and U32 macros in 178 # This warning is benignly triggered by the U16 and U32 macros in
175 # bytecode-utils.h. 179 # bytecode-utils.h.
176 # C4309: 'static_cast': truncation of constant value 180 # C4309: 'static_cast': truncation of constant value
177 cflags = [ "/wd4309" ] 181 cflags = [ "/wd4309" ]
178 } 182 }
179 } 183 }
OLDNEW
« no previous file with comments | « gni/v8.gni ('k') | test/unittests/unittests.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698