components/pref_registry/testing_pref_service_syncable.h - Issue 2479113002: Make extensions DSE persistent in browser prefs

Unified Diff: components/pref_registry/testing_pref_service_syncable.h

Issue 2479113002: Make extensions DSE persistent in browser prefs (Closed)

Patch Set: Tests updated(rewritten) after review Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/pref_registry/testing_pref_service_syncable.h

diff --git a/components/pref_registry/testing_pref_service_syncable.h b/components/pref_registry/testing_pref_service_syncable.h

index 80a11a1f0203c0b3dd697c8347bdb72d9f1eef1d..f4992e5658bb9e397abc49e434942d4a185f9862 100644

--- a/components/pref_registry/testing_pref_service_syncable.h

+++ b/components/pref_registry/testing_pref_service_syncable.h

@@ -18,6 +18,7 @@ class TestingPrefServiceSyncable

public:

TestingPrefServiceSyncable();

TestingPrefServiceSyncable(TestingPrefStore* managed_prefs,

vasilii 2016/12/06 19:16:42 How is this class different from components/sync_p

gab 2016/12/06 19:35:04 I'm also confused, maybe it wasn't properly remove

Bernhard Bauer 2016/12/07 15:36:40 No idea. It actually looks like it was added as a

hashimoto 2016/12/08 07:45:28 I added user_prefs::TestingPrefServiceSyncable (=

Alexander Yashkin 2016/12/09 08:19:52 I think this should be fixed, but not in the scope

sdefresne 2016/12/21 12:52:56 I don't know why they were not merged. We probably

+ TestingPrefStore* extension_prefs,

TestingPrefStore* user_prefs,

TestingPrefStore* recommended_prefs,

PrefRegistrySyncable* pref_registry,