Add user_prefs::TestPrefServiceSyncable

Add user_prefs::TestPrefServiceSyncable

BUG=386246
TEST=unit_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278292

[hashimoto, 2014-06-18 18:46:17]

Colin, could you review this change?

[blundell, 2014-06-18 19:40:28]

LGTM

Is the chrome-level class still needed?

Can the code in src/components/sync_driver/sync_prefs_unittest.cc be replaced by
using the new class?

[hashimoto, 2014-06-18 20:05:59]

On 2014/06/18 19:40:28, blundell wrote:
> LGTM
> 
> Is the chrome-level class still needed?
I guess it's needed because some classes need to use methods specific to
PrefServiceSyncable which lives in chrome/browser/prefs, instead of PrefService.
> 
> Can the code in src/components/sync_driver/sync_prefs_unittest.cc be replaced
by
> using the new class?
Thanks for letting me know.
This looks identical.
Replaced with the new one.

[hashimoto, 2014-06-18 20:06:53]

Peter, could you take a look at changes under chrome/browser/search_engines?

Colin, could you take another look at new changes under components?

[blundell, 2014-06-18 20:07:49]

SLGTM! Thanks!

[Peter Kasting, 2014-06-18 20:27:13]

LGTM

https://codereview.chromium.org/340703002/diff/60001/chrome/browser/search_en...
File chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc
(right):

https://codereview.chromium.org/340703002/diff/60001/chrome/browser/search_en...
chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc:96:
TemplateURLPrepopulateData::RegisterProfilePrefs(prefs.registry());
You seem to do this in every test, so I suggest converting
TemplateURLPrepopulateDataTest to a real subclass of testing::Test so you can
introduce a SetUp() override to do this.

[hashimoto, 2014-06-18 21:09:33]

https://codereview.chromium.org/340703002/diff/60001/chrome/browser/search_en...
File chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc
(right):

https://codereview.chromium.org/340703002/diff/60001/chrome/browser/search_en...
chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc:96:
TemplateURLPrepopulateData::RegisterProfilePrefs(prefs.registry());
On 2014/06/18 20:27:13, Peter Kasting wrote:
> You seem to do this in every test, so I suggest converting
> TemplateURLPrepopulateDataTest to a real subclass of testing::Test so you can
> introduce a SetUp() override to do this.

Done.
Added a test fixture and replaced all TEST with TEST_F

[hashimoto, 2014-06-18 22:27:48]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2014-06-18 22:28:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hashimoto@chromium.org/340703002/100001

[commit-bot: I haz the power, 2014-06-19 07:00:05]

Change committed as 278292