Make extensions DSE persistent in browser prefs

components/pref_registry/testing_pref_service_syncable.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PERF_REGISTRY_TESTING_PREF_SERVICE_SYNCABLE_H_

[Bernhard Bauer, 2016/12/07 15:36:40]

Also: lol, perf registry :)

 #define COMPONENTS_PERF_REGISTRY_TESTING_PREF_SERVICE_SYNCABLE_H_
 
 #include "base/macros.h"
 #include "components/prefs/testing_pref_service.h"
 
 namespace user_prefs {
 
 class PrefRegistrySyncable;
 
 // Test version of PrefServiceSyncable.
 class TestingPrefServiceSyncable
     : public TestingPrefServiceBase<PrefService, PrefRegistrySyncable> {
  public:
   TestingPrefServiceSyncable();
   TestingPrefServiceSyncable(TestingPrefStore* managed_prefs,

[vasilii, 2016/12/06 19:16:42]

How is this class different from
components/sync_preferences/testing_pref_service_syncable.h?
Do you use both?

[gab, 2016/12/06 19:35:04]

I'm also confused, maybe it wasn't properly removed in
https://codereview.chromium.org/1305213009?

+bauerb/sdefresne?

[Bernhard Bauer, 2016/12/07 15:36:40]

No idea. It actually looks like it was added as a duplicate in
https://codereview.chromium.org/340703002.

[hashimoto, 2016/12/08 07:45:28]

I added user_prefs::TestingPrefServiceSyncable (= PrefService in
components/prefs + PrefRegistrySyncable) for tests which cannot depend on
chrome, but requires PrefRegistrySyncable.
OTOH Chrome's ::TestingPrefServiceSyncable is PrefServiceSyncable in chrome +
PrefRegistrySyncable.
I couldn't remove ::TestingPrefServiceSyncable when adding
user_prefs::TestingPrefServiceSyncable because tests under chrome expects
PrefServiceSyncable, not PrefService.

Now PrefServiceSyncable is placed under components/syncable_prefs, so perhaps
it's OK to remove user_prefs::TestingPrefServiceSyncable and use
::TestingPrefServiceSyncable everywhere, if all existing users are OK with
depending on components/syncable_prefs.

[Alexander Yashkin, 2016/12/09 08:19:52]

I think this should be fixed, but not in the scope of current CL.

[sdefresne, 2016/12/21 12:52:56]

I don't know why they were not merged. We probably didn't notice the two really
similar classes then.

+                             TestingPrefStore* extension_prefs,
                              TestingPrefStore* user_prefs,
                              TestingPrefStore* recommended_prefs,
                              PrefRegistrySyncable* pref_registry,
                              PrefNotifierImpl* pref_notifier);
   ~TestingPrefServiceSyncable() override;
 
   // This is provided as a convenience; on a production PrefService
   // you would do all registrations before constructing it, passing it
   // a PrefRegistry via its constructor (or via e.g. PrefServiceFactory).
   PrefRegistrySyncable* registry();
 
  private:
   DISALLOW_COPY_AND_ASSIGN(TestingPrefServiceSyncable);
 };
 
 }  // namespace user_prefs
 
 #endif  // COMPONENTS_PERF_REGISTRY_TESTING_PREF_SERVICE_SYNCABLE_H_