Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 247903004: Enable settings in a window by default (Closed)

Created:
6 years, 8 months ago by stevenjb
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Enable by default for Chrome OS only #

Patch Set 4 : Rebase #

Patch Set 5 : Fix uber_ui.cc #

Patch Set 6 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -16 lines) Patch
M chrome/browser/about_flags.cc View 1 2 3 2 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.h View 1 2 3 4 5 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.cc View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/chrome_pages.cc View 1 2 3 3 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 1 2 3 4 5 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/uber/uber_ui.cc View 1 2 3 4 2 chunks +1 line, -6 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
stevenjb
Awaiting official UX go-ahead on this, but PTAL when you have a moment.
6 years, 8 months ago (2014-04-23 22:01:19 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 8 months ago (2014-04-23 22:08:50 UTC) #2
stevenjb
UX would like to enable this by default on Chrome OS only initially. PTAL
6 years, 7 months ago (2014-04-28 21:32:32 UTC) #3
Ben Goodger (Google)
lgtm
6 years, 7 months ago (2014-04-30 03:37:31 UTC) #4
stevenjb
The CQ bit was checked by stevenjb@chromium.org
6 years, 6 months ago (2014-06-11 16:58:35 UTC) #5
stevenjb
The CQ bit was unchecked by stevenjb@chromium.org
6 years, 6 months ago (2014-06-11 16:59:37 UTC) #6
stevenjb
The CQ bit was checked by stevenjb@chromium.org
6 years, 6 months ago (2014-06-11 18:33:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/247903004/60001
6 years, 6 months ago (2014-06-11 18:36:12 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 22:02:07 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 22:22:58 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/19734)
6 years, 6 months ago (2014-06-11 22:23:00 UTC) #11
stevenjb
The CQ bit was checked by stevenjb@chromium.org
6 years, 6 months ago (2014-06-12 16:40:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/247903004/80001
6 years, 6 months ago (2014-06-12 16:42:01 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-12 20:31:01 UTC) #14
stevenjb
6 years, 6 months ago (2014-06-13 00:43:12 UTC) #15
Message was sent while issue was closed. 
Committed patchset #6 manually as r276870 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698