Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: chrome/browser/about_flags.cc

Issue 247903004: Enable settings in a window by default (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix tests Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/browser_navigator_browsertest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index d7019f3b8844291968025aca74d854e3e6c33141..4a0aae93b0a8528a93becaa3ec64c279a4f53fd1 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -450,6 +450,14 @@ const Experiment::Choice kEnableFileManagerNewGalleryChoices[] = {
};
#endif
+const Experiment::Choice kEnableSettingsWindowChoices[] = {
+ { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
+ { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED,
+ ::switches::kEnableSettingsWindow, "" },
+ { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
+ ::switches::kDisableSettingsWindow, "" },
+};
+
// RECORDING USER METRICS FOR FLAGS:
// -----------------------------------------------------------------------------
// The first line of the experiment is the internal name. If you'd like to
@@ -1773,7 +1781,7 @@ const Experiment kExperiments[] = {
IDS_FLAGS_ENABLE_SETTINGS_WINDOW_NAME,
IDS_FLAGS_ENABLE_SETTINGS_WINDOW_DESCRIPTION,
kOsDesktop,
- SINGLE_VALUE_TYPE(switches::kEnableSettingsWindow)
+ MULTI_VALUE_TYPE(kEnableSettingsWindowChoices)
},
#if defined(OS_ANDROID)
{
« no previous file with comments | « no previous file | chrome/browser/ui/browser_navigator_browsertest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698