Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: chrome/browser/ui/chrome_pages.cc

Issue 247903004: Enable settings in a window by default (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix tests Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/chrome_pages.cc
diff --git a/chrome/browser/ui/chrome_pages.cc b/chrome/browser/ui/chrome_pages.cc
index e2c295c2fa4ad3d4b29bccc0e3d3561f9fd7f740..3b8e4be59ea6c3e0ec030f1ef412160ff238e652 100644
--- a/chrome/browser/ui/chrome_pages.cc
+++ b/chrome/browser/ui/chrome_pages.cc
@@ -108,11 +108,6 @@ void ShowHelpImpl(Browser* browser,
ShowSingletonTab(browser, url);
}
-bool IsSettingsWindowEnabled() {
- return CommandLine::ForCurrentProcess()->HasSwitch(
- ::switches::kEnableSettingsWindow);
-}
-
} // namespace
void ShowBookmarkManager(Browser* browser) {
@@ -234,7 +229,7 @@ void ShowSettings(Browser* browser) {
}
void ShowSettingsSubPage(Browser* browser, const std::string& sub_page) {
- if (IsSettingsWindowEnabled()) {
+ if (::switches::SettingsWindowEnabled()) {
ShowSettingsSubPageForProfile(browser->profile(), sub_page);
return;
}
@@ -243,7 +238,7 @@ void ShowSettingsSubPage(Browser* browser, const std::string& sub_page) {
void ShowSettingsSubPageForProfile(Profile* profile,
const std::string& sub_page) {
- if (IsSettingsWindowEnabled()) {
+ if (::switches::SettingsWindowEnabled()) {
content::RecordAction(base::UserMetricsAction("ShowOptions"));
SettingsWindowManager::GetInstance()->ShowChromePageForProfile(
profile, GetSettingsUrl(sub_page));
« no previous file with comments | « chrome/browser/ui/browser_navigator_browsertest.cc ('k') | chrome/browser/ui/omnibox/omnibox_view_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698