Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3225)

Unified Diff: chrome/common/chrome_switches.cc

Issue 247903004: Enable settings in a window by default (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix tests Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/chrome_switches.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/chrome_switches.cc
diff --git a/chrome/common/chrome_switches.cc b/chrome/common/chrome_switches.cc
index ed7586cb2d8e6538a22104a7cfaa34ca506199da..fed9789fdb59eb54ae4bfe3f6512e2924683982a 100644
--- a/chrome/common/chrome_switches.cc
+++ b/chrome/common/chrome_switches.cc
@@ -599,8 +599,10 @@ const char kEnableSearchButtonInOmniboxForStrOrIip[] =
// Enables using bubbles for session restore request instead of infobars.
const char kEnableSessionCrashedBubble[] = "enable-session-crashed-bubble";
-// Enable settings in a separate browser window per profile.
-const char kEnableSettingsWindow[] = "enable-settings-window";
+// Enable or disable settings in a separate browser window per profile
+// (see SettingsWindowEnabled() below).
+const char kEnableSettingsWindow[] = "enable-settings-window";
+const char kDisableSettingsWindow[] = "disable-settings-window";
// Enable SPDY/4, aka HTTP/2. This is a temporary testing flag.
const char kEnableSpdy4[] = "enable-spdy4";
@@ -1388,6 +1390,16 @@ const char kDebugPrint[] = "debug-print";
const char kFileManagerExtensionPath[] = "filemgr-ext-path";
#endif
+bool SettingsWindowEnabled() {
+#if defined(OS_CHROMEOS)
+ return !CommandLine::ForCurrentProcess()->HasSwitch(
+ ::switches::kDisableSettingsWindow);
+#else
+ return CommandLine::ForCurrentProcess()->HasSwitch(
+ ::switches::kEnableSettingsWindow);
+#endif
+}
+
// -----------------------------------------------------------------------------
// DO NOT ADD YOUR CRAP TO THE BOTTOM OF THIS FILE.
//
« no previous file with comments | « chrome/common/chrome_switches.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698