Issue 247793002: HPACK: Refactor and simplify HpackOutputStream

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 247793002: HPACK: Refactor and simplify HpackOutputStream (Closed)

Created:
6 years, 8 months ago by Johnny

Modified:
6 years, 7 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

HPACK: Refactor and simplify HpackOutputStream HpackOutputStream is no longer responsible for emitting entire opcodes. That will be the encoder's job. Instead, it simply provides primitives for emitting prefixes, varints, and byte arrays. The longer-term intent is that HpackOutputStream will be merged into SpdyFrameBuilder and eliminated altogether. HpackOutputStream also no longer asserts a maximum literal length. Rationale is that we already have a theoretical too-long header at this point: we might as well emit it and allow the remote decoder to possibly accept it. At worst we break the connection, which was going to happen anyway. This lands server change 65186763 by jgraettinger. BUG=339578

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -180 lines)			Patch
M	net/spdy/hpack_decoder_test.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	net/spdy/hpack_encoder.h	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	net/spdy/hpack_encoder.cc	View	2 chunks	+17 lines, -8 lines	0 comments	Download
M	net/spdy/hpack_encoder_test.cc	View	1 chunk	+0 lines, -16 lines	0 comments	Download
M	net/spdy/hpack_huffman_table_test.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	net/spdy/hpack_output_stream.h	View	3 chunks	+8 lines, -41 lines	0 comments	Download
M	net/spdy/hpack_output_stream.cc	View	3 chunks	+14 lines, -37 lines	0 comments	Download
M	net/spdy/hpack_output_stream_test.cc	View	3 chunks	+18 lines, -66 lines	0 comments	Download
M	net/spdy/spdy_framer_test.cc	View	1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages