HPACK: Refactor and simplify HpackOutputStream

net/spdy/hpack_decoder_test.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/hpack_decoder.h"
 
 #include <map>
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 234 matching lines @@
   EXPECT_EQ(kDefaultHeaderTableSizeSetting,
             decoder_peer_.header_table().max_size());
   {
     // Maximum-size update with size 126. Succeeds.
     EXPECT_TRUE(DecodeHeaderBlock(StringPiece("\x80\x7e", 2)));
     EXPECT_EQ(126u, decoder_peer_.header_table().max_size());
   }
   string input;
   {
     // Maximum-size update with kDefaultHeaderTableSizeSetting. Succeeds.
-    HpackOutputStream output_stream(kuint32max);
+    HpackOutputStream output_stream;
     output_stream.AppendBits(0x80, 8);  // Context update.
     output_stream.AppendBits(0x00, 1);  // Size update.
-    output_stream.AppendUint32ForTest(kDefaultHeaderTableSizeSetting);
+    output_stream.AppendUint32(kDefaultHeaderTableSizeSetting);
 
     output_stream.TakeString(&input);
     EXPECT_TRUE(DecodeHeaderBlock(StringPiece(input)));
     EXPECT_EQ(kDefaultHeaderTableSizeSetting,
               decoder_peer_.header_table().max_size());
   }
   {
     // Maximum-size update with kDefaultHeaderTableSizeSetting + 1. Fails.
-    HpackOutputStream output_stream(kuint32max);
+    HpackOutputStream output_stream;
     output_stream.AppendBits(0x80, 8);  // Context update.
     output_stream.AppendBits(0x00, 1);  // Size update.
-    output_stream.AppendUint32ForTest(kDefaultHeaderTableSizeSetting + 1);
+    output_stream.AppendUint32(kDefaultHeaderTableSizeSetting + 1);
 
     output_stream.TakeString(&input);
     EXPECT_FALSE(DecodeHeaderBlock(StringPiece(input)));
     EXPECT_EQ(kDefaultHeaderTableSizeSetting,
               decoder_peer_.header_table().max_size());
   }
 }
 
 TEST_F(HpackDecoderTest, ContextUpdateClearReferenceSet) {
   // Toggle on a couple of headers.
@@ skipping 318 matching lines @@
       Pair("content-encoding", "gzip"),
       Pair("date", "Mon, 21 Oct 2013 20:13:22 GMT"),
       Pair("location", "https://www.example.com"),
       Pair("set-cookie", "foo=ASDJKHQKBZXOQWEOPIUAXQWEOIU;"
            " max-age=3600; version=1")));
 }
 
 }  // namespace
 
 }  // namespace net