HPACK: Refactor and simplify HpackOutputStream

net/spdy/hpack_huffman_table_test.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/hpack_huffman_table.h"
 
 #include <bitset>
 #include <string>
 
 #include "base/logging.h"
@@ skipping 242 matching lines @@
   char input_storage[] = {2, 3, 2, 7, 4};
   StringPiece input(input_storage, arraysize(input_storage));
   // By symbol: (2) 00 (3) 010 (2) 00 (7) 10010 (4) 10000 (6 as pad) 1001100.
   char expect_storage[] = {
     bits8("00010001"),
     bits8("00101000"),
     bits8("01001100")};
   StringPiece expect(expect_storage, arraysize(expect_storage));
 
   string buffer_in, buffer_out;
-  HpackOutputStream output_stream(kuint32max);
+  HpackOutputStream output_stream;
   table.EncodeString(input, &output_stream);
   output_stream.TakeString(&buffer_in);
   EXPECT_EQ(buffer_in, expect);
 
   HpackInputStream input_stream(kuint32max, buffer_in);
   EXPECT_TRUE(table.DecodeString(&input_stream, input.size(), &buffer_out));
   EXPECT_EQ(buffer_out, input);
 }
 
 TEST(HpackHuffmanTableTest, ValidateMultiLevelDecodeTables) {
@@ skipping 109 matching lines @@
     "\x4e\xb0\x8b\x74\x97\x90\xfa\x7f",
     "custom-key",
     "\x4e\xb0\x8b\x74\x97\x9a\x17\xa8\xff",
     "custom-value",
   };
   // Round-trip each test example.
   for (size_t i = 0; i != arraysize(test_table); i += 2) {
     const string& encoded(test_table[i]);
     const string& decoded(test_table[i+1]);
     HpackInputStream input_stream(kuint32max, encoded);
-    HpackOutputStream output_stream(kuint32max);
+    HpackOutputStream output_stream;
 
     buffer.reserve(decoded.size());
     EXPECT_TRUE(table.DecodeString(&input_stream, decoded.size(), &buffer));
     EXPECT_EQ(decoded, buffer);
     table.EncodeString(decoded, &output_stream);
     output_stream.TakeString(&buffer);
     EXPECT_EQ(encoded, buffer);
   }
 }
 
@@ skipping 15 matching lines @@
         "\xfb\x7e\xbb\xbe\x9f\x5f\x87\xe3\x7f\xef\xed\xfa\xee\xfa\x7c\x3f"
         "\x1d\x5d\x1a\x23\xce\x54\x64\x36\xcd\x49\x4b\xd5\xd1\xcc\x5f\x05"
         "\x35\x96\x9b",
     "foo=ASDJKHQKBZXOQWEOPIUAXQWEOIU; max-age=3600; version=1",
   };
   // Round-trip each test example.
   for (size_t i = 0; i != arraysize(test_table); i += 2) {
     const string& encoded(test_table[i]);
     const string& decoded(test_table[i+1]);
     HpackInputStream input_stream(kuint32max, encoded);
-    HpackOutputStream output_stream(kuint32max);
+    HpackOutputStream output_stream;
 
     buffer.reserve(decoded.size());
     EXPECT_TRUE(table.DecodeString(&input_stream, decoded.size(), &buffer));
     EXPECT_EQ(decoded, buffer);
     table.EncodeString(decoded, &output_stream);
     output_stream.TakeString(&buffer);
     EXPECT_EQ(encoded, buffer);
   }
 }
 
 TEST(HpackHuffmanTableTest, RoundTripIndvidualSymbols) {
   const HpackHuffmanTable& table(ObtainHpackHuffmanTable());
 
   for (size_t i = 0; i != 256; i++) {
     char c = static_cast<char>(i);
     char storage[3] = {c, c, c};
     StringPiece input(storage, arraysize(storage));
 
     string buffer_in, buffer_out(input.size(), '\0');
-    HpackOutputStream output_stream(kuint32max);
+    HpackOutputStream output_stream;
     table.EncodeString(input, &output_stream);
     output_stream.TakeString(&buffer_in);
 
     HpackInputStream input_stream(kuint32max, buffer_in);
     EXPECT_TRUE(table.DecodeString(&input_stream, input.size(), &buffer_out));
     EXPECT_EQ(input, buffer_out);
   }
 }
 
 TEST(HpackHuffmanTableTest, RoundTripSymbolSequence) {
   const HpackHuffmanTable& table(ObtainHpackHuffmanTable());
 
   char storage[512];
   for (size_t i = 0; i != 256; i++) {
     storage[i] = static_cast<char>(i);
     storage[511 - i] = static_cast<char>(i);
   }
   StringPiece input(storage, arraysize(storage));
 
   string buffer_in, buffer_out(input.size(), '\0');
-  HpackOutputStream output_stream(kuint32max);
+  HpackOutputStream output_stream;
   table.EncodeString(input, &output_stream);
   output_stream.TakeString(&buffer_in);
 
   HpackInputStream input_stream(kuint32max, buffer_in);
   EXPECT_TRUE(table.DecodeString(&input_stream, input.size(), &buffer_out));
   EXPECT_EQ(input, buffer_out);
 }
 
 }  // namespace
 
 }  // namespace test
 
 }  // namespace net