Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1120)

Unified Diff: net/spdy/hpack_encoder_test.cc

Issue 247793002: HPACK: Refactor and simplify HpackOutputStream (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/hpack_encoder.cc ('k') | net/spdy/hpack_huffman_table_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/hpack_encoder_test.cc
diff --git a/net/spdy/hpack_encoder_test.cc b/net/spdy/hpack_encoder_test.cc
index 316952edd0dcbd4fe4e91f628b5e3b0cb59ffc46..34e980dc7fd2988ad83b8982f7f63cc475589a87 100644
--- a/net/spdy/hpack_encoder_test.cc
+++ b/net/spdy/hpack_encoder_test.cc
@@ -96,22 +96,6 @@ TEST(HpackEncoderTest, CookieCrumbling) {
"\x40\x06""Cookie\x0bkey2=value2", encoded_header_set);
}
-// Test that trying to encode a header set with a too-long header
-// field will fail.
-TEST(HpackEncoderTest, HeaderTooLarge) {
- HpackEncoder encoder;
- test::HpackEncoderPeer(&encoder).set_max_string_literal_size(10);
-
- std::map<string, string> header_set;
- header_set["name1"] = "too-long value";
- header_set["name2"] = "value2";
-
- // TODO(akalin): Verify that the encoder did not attempt to encode
- // the second header field.
- string encoded_header_set;
- EXPECT_FALSE(encoder.EncodeHeaderSet(header_set, &encoded_header_set));
-}
-
} // namespace
} // namespace net
« no previous file with comments | « net/spdy/hpack_encoder.cc ('k') | net/spdy/hpack_huffman_table_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698