Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2476983002: Fix null annotations, and move checks into RequestFinishedInfo (Closed)

Created:
4 years, 1 month ago by mgersh
Modified:
4 years, 1 month ago
Reviewers:
kapishnikov, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, agrieve+watch_chromium.org, xunjieli
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix null annotations, and move checks into RequestFinishedInfo RequestFinishedInfo.getAnnotations() was returning null instead of an empty collection when used with BidirectionalStream. It now returns an empty collection instead, and the code to do this is moved out of the builders into RequestFinishedInfo. BUG=662409 Committed: https://crrev.com/e9d1b6c7804b11669012145c313e9adc58271684 Cr-Commit-Position: refs/heads/master@{#430013}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M components/cronet/android/api/src/org/chromium/net/RequestFinishedInfo.java View 2 chunks +4 lines, -0 lines 0 comments Download
M components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java View 1 chunk +0 lines, -3 lines 0 comments Download
M components/cronet/android/java/src/org/chromium/net/impl/UrlRequestBuilderImpl.java View 3 chunks +2 lines, -3 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java View 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mgersh
New version of the one I sent before lunch. PTAL.
4 years, 1 month ago (2016-11-04 17:17:09 UTC) #2
xunjieli
lgtm
4 years, 1 month ago (2016-11-04 17:20:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2476983002/1
4 years, 1 month ago (2016-11-04 20:47:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 21:08:08 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 21:10:20 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e9d1b6c7804b11669012145c313e9adc58271684
Cr-Commit-Position: refs/heads/master@{#430013}

Powered by Google App Engine
This is Rietveld 408576698