components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java - Issue 2476983002: Fix null annotations, and move checks into RequestFinishedInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java

Issue 2476983002: Fix null annotations, and move checks into RequestFinishedInfo (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/api/src/org/chromium/net/RequestFinishedInfo.java ('k') | components/cronet/android/java/src/org/chromium/net/impl/UrlRequestBuilderImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java

diff --git a/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java b/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java

index 9bbdfcdb16941d21456c08d3784fd33f5eb7704d..22c226f88dbfbb66612c46c14dca8fe5d5253472 100644

--- a/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java

+++ b/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java

@@ -138,9 +138,6 @@ public final class CronetUrlRequest extends UrlRequestBase {

if (executor == null) {

throw new NullPointerException("Executor is required");

}

- if (requestAnnotations == null) {

- throw new NullPointerException("requestAnnotations is required");

- }

mAllowDirectExecutor = allowDirectExecutor;

mRequestContext = requestContext;