Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java

Issue 2476983002: Fix null annotations, and move checks into RequestFinishedInfo (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/impl/UrlRequestBuilderImpl.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java
index 1f5737be50e3df32e7c1034d09397ce6ce5cf26c..ba932d803c5524f8ce95511459086cbd833be1ad 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java
@@ -94,6 +94,8 @@ public class BidirectionalStreamTest extends CronetTestBase {
throws Exception {
String url = Http2TestServer.getEchoMethodUrl();
TestBidirectionalStreamCallback callback = new TestBidirectionalStreamCallback();
+ TestRequestFinishedListener requestFinishedListener = new TestRequestFinishedListener();
+ mTestFramework.mCronetEngine.addRequestFinishedListener(requestFinishedListener);
// Create stream.
BidirectionalStream stream =
mTestFramework.mCronetEngine
@@ -103,6 +105,7 @@ public class BidirectionalStreamTest extends CronetTestBase {
stream.start();
callback.blockForDone();
assertTrue(stream.isDone());
+ requestFinishedListener.blockUntilDone();
assertEquals(200, callback.mResponseInfo.getHttpStatusCode());
// Default method is 'GET'.
assertEquals("GET", callback.mResponseAsString);
@@ -110,6 +113,8 @@ public class BidirectionalStreamTest extends CronetTestBase {
new String[] {url}, "", 200, expectedReceivedBytes, ":status", "200");
assertResponseEquals(urlResponseInfo, callback.mResponseInfo);
checkResponseInfo(callback.mResponseInfo, Http2TestServer.getEchoMethodUrl(), 200, "");
+ RequestFinishedInfo finishedInfo = requestFinishedListener.getRequestInfo();
+ assertTrue(finishedInfo.getAnnotations().isEmpty());
}
@SmallTest
« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/impl/UrlRequestBuilderImpl.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698