Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: components/cronet/android/java/src/org/chromium/net/impl/UrlRequestBuilderImpl.java

Issue 2476983002: Fix null annotations, and move checks into RequestFinishedInfo (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/java/src/org/chromium/net/impl/UrlRequestBuilderImpl.java
diff --git a/components/cronet/android/java/src/org/chromium/net/impl/UrlRequestBuilderImpl.java b/components/cronet/android/java/src/org/chromium/net/impl/UrlRequestBuilderImpl.java
index 10bc376198d6d3531751cf35cad63a820273f514..59e0af21b8cc8110e7e0e40efe5a12f12028b406 100644
--- a/components/cronet/android/java/src/org/chromium/net/impl/UrlRequestBuilderImpl.java
+++ b/components/cronet/android/java/src/org/chromium/net/impl/UrlRequestBuilderImpl.java
@@ -14,7 +14,6 @@ import org.chromium.net.UrlRequest;
import java.util.ArrayList;
import java.util.Collection;
-import java.util.Collections;
import java.util.concurrent.Executor;
/**
@@ -48,7 +47,7 @@ public class UrlRequestBuilderImpl extends ExperimentalUrlRequest.Builder {
@CronetEngineBase.RequestPriority
private int mPriority = REQUEST_PRIORITY_MEDIUM;
// Request reporting annotations. Avoid extra object creation if no annotations added.
- private Collection<Object> mRequestAnnotations = Collections.emptyList();
+ private Collection<Object> mRequestAnnotations;
// If request is an upload, this provides the request body data.
private UploadDataProvider mUploadDataProvider;
// Executor to call upload data provider back on.
@@ -162,7 +161,7 @@ public class UrlRequestBuilderImpl extends ExperimentalUrlRequest.Builder {
if (annotation == null) {
throw new NullPointerException("Invalid metrics annotation.");
}
- if (mRequestAnnotations.isEmpty()) {
+ if (mRequestAnnotations == null) {
mRequestAnnotations = new ArrayList<>();
}
mRequestAnnotations.add(annotation);

Powered by Google App Engine
This is Rietveld 408576698