Service Manager: Rework Service and ServiceContext lifetime

Service Manager: Rework Service and ServiceContext lifetime

Changes ServiceContext to always own a Service instance.

Changes Service::OnStart() to only take a ServiceContext* which
is guaranteed to outlive the Service.

Updates all the code affected by this change, including content's
EmbeddedServiceRunner which will now always create a new Service
instance per incoming ServiceRequest.

Also fixes a bunch of IWYU violations.

BUG=654986
Committed: https://crrev.com/b92eed3a5cd6cde768bd32a74487c45094bccbdf
Cr-Commit-Position: refs/heads/master@{#430131}

[Ken Rockot(use gerrit already), 2016-11-05 00:01:31]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-05 00:02:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-11-05 00:02:39]

rockot@chromium.org changed reviewers:
+ ben@chromium.org

[Ken Rockot(use gerrit already), 2016-11-05 00:02:40]

wheeeee

[commit-bot: I haz the power, 2016-11-05 00:24:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-05 00:24:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2016-11-05 00:33:46]

lgtm

[Ken Rockot(use gerrit already), 2016-11-05 00:35:55]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[Ken Rockot(use gerrit already), 2016-11-05 00:36:09]

Description was changed from

==========
Rework Service and ServiceContext lifetime

Changes ServiceContext to always own a Service instance.

Changes Service::OnStart() to only take a ServiceContext* which
is guaranteed to outlive the Service.

Updates a all the code affected by this change, including content's
EmbeddedServiceRunner which will now always create a new Service
instance per incoming ServiceRequest.

Also fixes a bunch of IWYU violations.

BUG=654986
==========

to

==========
Rework Service and ServiceContext lifetime

Changes ServiceContext to always own a Service instance.

Changes Service::OnStart() to only take a ServiceContext* which
is guaranteed to outlive the Service.

Updates all the code affected by this change, including content's
EmbeddedServiceRunner which will now always create a new Service
instance per incoming ServiceRequest.

Also fixes a bunch of IWYU violations.

BUG=654986
==========

[commit-bot: I haz the power, 2016-11-05 00:36:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-11-05 00:40:25]

Description was changed from

==========
Rework Service and ServiceContext lifetime

Changes ServiceContext to always own a Service instance.

Changes Service::OnStart() to only take a ServiceContext* which
is guaranteed to outlive the Service.

Updates all the code affected by this change, including content's
EmbeddedServiceRunner which will now always create a new Service
instance per incoming ServiceRequest.

Also fixes a bunch of IWYU violations.

BUG=654986
==========

to

==========
Service Manager: Rework Service and ServiceContext lifetime

Changes ServiceContext to always own a Service instance.

Changes Service::OnStart() to only take a ServiceContext* which
is guaranteed to outlive the Service.

Updates all the code affected by this change, including content's
EmbeddedServiceRunner which will now always create a new Service
instance per incoming ServiceRequest.

Also fixes a bunch of IWYU violations.

BUG=654986
==========

[commit-bot: I haz the power, 2016-11-05 00:56:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-05 00:56:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2016-11-05 00:57:45]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-05 00:58:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-11-05 01:07:05]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-05 01:07:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-11-05 01:55:59]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-11-05 01:56:01]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-11-05 01:56:02]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org
Link to the patchset: https://codereview.chromium.org/2476063002/#ps60001
(title: ".")

[commit-bot: I haz the power, 2016-11-05 01:56:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-05 02:45:25]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-05 02:47:20]

Description was changed from

==========
Service Manager: Rework Service and ServiceContext lifetime

Changes ServiceContext to always own a Service instance.

Changes Service::OnStart() to only take a ServiceContext* which
is guaranteed to outlive the Service.

Updates all the code affected by this change, including content's
EmbeddedServiceRunner which will now always create a new Service
instance per incoming ServiceRequest.

Also fixes a bunch of IWYU violations.

BUG=654986
==========

to

==========
Service Manager: Rework Service and ServiceContext lifetime

Changes ServiceContext to always own a Service instance.

Changes Service::OnStart() to only take a ServiceContext* which
is guaranteed to outlive the Service.

Updates all the code affected by this change, including content's
EmbeddedServiceRunner which will now always create a new Service
instance per incoming ServiceRequest.

Also fixes a bunch of IWYU violations.

BUG=654986

Committed: https://crrev.com/b92eed3a5cd6cde768bd32a74487c45094bccbdf
Cr-Commit-Position: refs/heads/master@{#430131}
==========

[commit-bot: I haz the power, 2016-11-05 02:47:22]

Patchset 4 (id:??) landed as
https://crrev.com/b92eed3a5cd6cde768bd32a74487c45094bccbdf
Cr-Commit-Position: refs/heads/master@{#430131}