Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1619)

Unified Diff: services/service_manager/public/cpp/interface_registry.h

Issue 2476063002: Service Manager: Rework Service and ServiceContext lifetime (Closed)
Patch Set: . Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/service_manager/public/cpp/interface_registry.h
diff --git a/services/service_manager/public/cpp/interface_registry.h b/services/service_manager/public/cpp/interface_registry.h
index fa7b898226a528c2445a6706bd2088c7d4cc0199..5872478342f91bbbd09a4e500aa5a1b74f4bae99 100644
--- a/services/service_manager/public/cpp/interface_registry.h
+++ b/services/service_manager/public/cpp/interface_registry.h
@@ -150,7 +150,9 @@ class InterfaceRegistry : public mojom::InterfaceProvider {
// Populates a set with the interface names this registry can bind.
void GetInterfaceNames(std::set<std::string>* interface_names);
- // Sets a closure to be run when the InterfaceProvider pipe is closed.
+ // Sets a closure to be run when the InterfaceProvider pipe is closed. Note
+ // that by the time any added closure is invoked, the InterfaceRegistry may
+ // have been deleted.
void AddConnectionLostClosure(const base::Closure& connection_lost_closure);
private:

Powered by Google App Engine
This is Rietveld 408576698