Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1166)

Unified Diff: services/service_manager/background/tests/background_service_manager_unittest.cc

Issue 2476063002: Service Manager: Rework Service and ServiceContext lifetime (Closed)
Patch Set: . Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/navigation/view_impl.h ('k') | services/service_manager/public/cpp/interface_registry.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/service_manager/background/tests/background_service_manager_unittest.cc
diff --git a/services/service_manager/background/tests/background_service_manager_unittest.cc b/services/service_manager/background/tests/background_service_manager_unittest.cc
index 45e00229033f94a82a2635af47cc4bb19eba1f9d..ad4a003d45c01a4a1cb356b2dd90b693ca9c85d2 100644
--- a/services/service_manager/background/tests/background_service_manager_unittest.cc
+++ b/services/service_manager/background/tests/background_service_manager_unittest.cc
@@ -25,6 +25,12 @@ class ServiceImpl : public Service {
ServiceImpl() {}
~ServiceImpl() override {}
+ // Service:
+ bool OnConnect(const ServiceInfo& remote_info,
+ InterfaceRegistry* registry) override {
+ return false;
+ }
+
private:
DISALLOW_COPY_AND_ASSIGN(ServiceImpl);
};
@@ -50,9 +56,9 @@ TEST(BackgroundServiceManagerTest, MAYBE_Basic) {
BackgroundServiceManager background_service_manager;
base::MessageLoop message_loop;
background_service_manager.Init(nullptr);
- ServiceImpl service;
ServiceContext service_context(
- &service, background_service_manager.CreateServiceRequest(kTestName));
+ base::MakeUnique<ServiceImpl>(),
+ background_service_manager.CreateServiceRequest(kTestName));
mojom::TestServicePtr test_service;
service_context.connector()->ConnectToInterface(kAppName, &test_service);
base::RunLoop run_loop;
« no previous file with comments | « services/navigation/view_impl.h ('k') | services/service_manager/public/cpp/interface_registry.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698