Service Manager: Rework Service and ServiceContext lifetime

services/service_manager/public/cpp/interface_registry.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SERVICES_SERVICE_MANAGER_PUBLIC_CPP_INTERFACE_REGISTRY_H_
 #define SERVICES_SERVICE_MANAGER_PUBLIC_CPP_INTERFACE_REGISTRY_H_
 
 #include <list>
 #include <memory>
 #include <queue>
@@ skipping 132 matching lines @@
   // requests will be queued internally and dispatched once ResumeBinding() is
   // called.
   void PauseBinding();
 
   // Resumes incoming interface request binding.
   void ResumeBinding();
 
   // Populates a set with the interface names this registry can bind.
   void GetInterfaceNames(std::set<std::string>* interface_names);
 
-  // Sets a closure to be run when the InterfaceProvider pipe is closed.
+  // Sets a closure to be run when the InterfaceProvider pipe is closed. Note
+  // that by the time any added closure is invoked, the InterfaceRegistry may
+  // have been deleted.
   void AddConnectionLostClosure(const base::Closure& connection_lost_closure);
 
  private:
   using InterfaceNameToBinderMap =
       std::map<std::string, std::unique_ptr<InterfaceBinder>>;
 
   // mojom::InterfaceProvider:
   void GetInterface(const std::string& interface_name,
                     mojo::ScopedMessagePipeHandle handle) override;
 
@@ skipping 51 matching lines @@
   std::list<base::Closure> connection_lost_closures_;
 
   base::WeakPtrFactory<InterfaceRegistry> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(InterfaceRegistry);
 };
 
 }  // namespace service_manager
 
 #endif  // SERVICES_SERVICE_MANAGER_PUBLIC_CPP_INTERFACE_REGISTRY_H_