Clamping shouldn't clear the fragment anchor.
Also rename fragment anchor tests for clarity.
BUG=661359
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Committed: https://crrev.com/1c73e92a39a2e894b32a318900d0730f8ae7b68e
Cr-Commit-Position: refs/heads/master@{#429581}
Description was changed from
==========
Clamping shouldn't clear the fragment anchor.
BUG=661359
==========
to
==========
Clamping shouldn't clear the fragment anchor.
BUG=661359
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========
skobes
The CQ bit was checked by skobes@chromium.org to run a CQ dry run
Description was changed from ========== Clamping shouldn't clear the fragment anchor. BUG=661359 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ...
Description was changed from
==========
Clamping shouldn't clear the fragment anchor.
BUG=661359
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========
to
==========
Clamping shouldn't clear the fragment anchor.
Also rename fragment anchor tests for clarity.
BUG=661359
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========
4 years, 1 month ago
(2016-11-03 02:55:37 UTC)
#10
Dry run: This issue passed the CQ dry run.
bokan
lgtm https://codereview.chromium.org/2474813002/diff/20001/third_party/WebKit/LayoutTests/fast/loader/clamping-preserves-fragment-anchor.html File third_party/WebKit/LayoutTests/fast/loader/clamping-preserves-fragment-anchor.html (right): https://codereview.chromium.org/2474813002/diff/20001/third_party/WebKit/LayoutTests/fast/loader/clamping-preserves-fragment-anchor.html#newcode30 third_party/WebKit/LayoutTests/fast/loader/clamping-preserves-fragment-anchor.html:30: document.body.className = "shrink"; This both shrinks the body ...
4 years, 1 month ago
(2016-11-03 11:19:12 UTC)
#11
+jbroman for Source/platform/OWNERS https://codereview.chromium.org/2474813002/diff/20001/third_party/WebKit/LayoutTests/fast/loader/clamping-preserves-fragment-anchor.html File third_party/WebKit/LayoutTests/fast/loader/clamping-preserves-fragment-anchor.html (right): https://codereview.chromium.org/2474813002/diff/20001/third_party/WebKit/LayoutTests/fast/loader/clamping-preserves-fragment-anchor.html#newcode30 third_party/WebKit/LayoutTests/fast/loader/clamping-preserves-fragment-anchor.html:30: document.body.className = "shrink"; On 2016/11/03 11:19:12, ...
4 years, 1 month ago
(2016-11-03 13:31:42 UTC)
#15
+jbroman for Source/platform/OWNERS
https://codereview.chromium.org/2474813002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/loader/clamping-preserves-fragment-anchor.html
(right):
https://codereview.chromium.org/2474813002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/loader/clamping-preserves-fragment-anchor.html:30:
document.body.className = "shrink";
On 2016/11/03 11:19:12, bokan wrote:
> This both shrinks the body and moves the <a>. Maybe split this up into two
> statements that explicitly shrink the body first, then move the <a> up? It'd
be
> less dependent on the order the clamp and fragment anchoring happen.
Done.
jbroman
platform lgtm
4 years, 1 month ago
(2016-11-03 14:20:16 UTC)
#16
platform lgtm
skobes
The CQ bit was unchecked by skobes@chromium.org
4 years, 1 month ago
(2016-11-03 14:33:19 UTC)
#17
Description was changed from ========== Clamping shouldn't clear the fragment anchor. Also rename fragment anchor ...
4 years, 1 month ago
(2016-11-03 14:48:07 UTC)
#21
Message was sent while issue was closed.
Description was changed from
==========
Clamping shouldn't clear the fragment anchor.
Also rename fragment anchor tests for clarity.
BUG=661359
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========
to
==========
Clamping shouldn't clear the fragment anchor.
Also rename fragment anchor tests for clarity.
BUG=661359
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago
(2016-11-03 14:48:10 UTC)
#22
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
commit-bot: I haz the power
Description was changed from ========== Clamping shouldn't clear the fragment anchor. Also rename fragment anchor ...
4 years, 1 month ago
(2016-11-03 14:50:21 UTC)
#23
Message was sent while issue was closed.
Description was changed from
==========
Clamping shouldn't clear the fragment anchor.
Also rename fragment anchor tests for clarity.
BUG=661359
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========
to
==========
Clamping shouldn't clear the fragment anchor.
Also rename fragment anchor tests for clarity.
BUG=661359
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Committed: https://crrev.com/1c73e92a39a2e894b32a318900d0730f8ae7b68e
Cr-Commit-Position: refs/heads/master@{#429581}
==========
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/1c73e92a39a2e894b32a318900d0730f8ae7b68e Cr-Commit-Position: refs/heads/master@{#429581}
4 years, 1 month ago
(2016-11-03 14:50:22 UTC)
#24
Issue 2474813002: Clamping shouldn't clear the fragment anchor.
(Closed)
Created 4 years, 1 month ago by skobes
Modified 4 years, 1 month ago
Reviewers: jbroman, bokan
Base URL:
Comments: 2