Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2474813002: Clamping shouldn't clear the fragment anchor. (Closed)

Created:
4 years, 1 month ago by skobes
Modified:
4 years, 1 month ago
Reviewers:
bokan, jbroman
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clamping shouldn't clear the fragment anchor. Also rename fragment anchor tests for clarity. BUG=661359 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/1c73e92a39a2e894b32a318900d0730f8ae7b68e Cr-Commit-Position: refs/heads/master@{#429581}

Patch Set 1 #

Patch Set 2 : add test #

Total comments: 2

Patch Set 3 : address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -110 lines) Patch
A third_party/WebKit/LayoutTests/fast/loader/clamping-preserves-fragment-anchor.html View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/loader/fragment-anchor-cleared-after-load.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/loader/fragment-anchor-cleared-after-load-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/loader/fragment-anchor-cleared-after-load-when-hidden.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/loader/fragment-anchor-cleared-after-load-when-hidden-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/loader/scroll-anchor-cleared-after-load.html View 1 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/loader/scroll-anchor-cleared-after-load-expected.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/loader/scroll-anchor-cleared-after-load-when-hidden.html View 1 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/loader/scroll-anchor-cleared-after-load-when-hidden-expected.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollTypes.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (17 generated)
skobes
4 years, 1 month ago (2016-11-03 00:22:44 UTC) #6
bokan
lgtm https://codereview.chromium.org/2474813002/diff/20001/third_party/WebKit/LayoutTests/fast/loader/clamping-preserves-fragment-anchor.html File third_party/WebKit/LayoutTests/fast/loader/clamping-preserves-fragment-anchor.html (right): https://codereview.chromium.org/2474813002/diff/20001/third_party/WebKit/LayoutTests/fast/loader/clamping-preserves-fragment-anchor.html#newcode30 third_party/WebKit/LayoutTests/fast/loader/clamping-preserves-fragment-anchor.html:30: document.body.className = "shrink"; This both shrinks the body ...
4 years, 1 month ago (2016-11-03 11:19:12 UTC) #11
skobes
+jbroman for Source/platform/OWNERS https://codereview.chromium.org/2474813002/diff/20001/third_party/WebKit/LayoutTests/fast/loader/clamping-preserves-fragment-anchor.html File third_party/WebKit/LayoutTests/fast/loader/clamping-preserves-fragment-anchor.html (right): https://codereview.chromium.org/2474813002/diff/20001/third_party/WebKit/LayoutTests/fast/loader/clamping-preserves-fragment-anchor.html#newcode30 third_party/WebKit/LayoutTests/fast/loader/clamping-preserves-fragment-anchor.html:30: document.body.className = "shrink"; On 2016/11/03 11:19:12, ...
4 years, 1 month ago (2016-11-03 13:31:42 UTC) #15
jbroman
platform lgtm
4 years, 1 month ago (2016-11-03 14:20:16 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474813002/40001
4 years, 1 month ago (2016-11-03 14:34:07 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-03 14:48:10 UTC) #22
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 14:50:22 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1c73e92a39a2e894b32a318900d0730f8ae7b68e
Cr-Commit-Position: refs/heads/master@{#429581}

Powered by Google App Engine
This is Rietveld 408576698