third_party/WebKit/Source/core/frame/FrameView.cpp - Issue 2474813002: Clamping shouldn't clear the fragment anchor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2474813002: Clamping shouldn't clear the fragment anchor. (Closed)

Patch Set: address review comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/FrameView.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp

index d72cf5eeb900e3de2c4832ecce03c1e90cefbd1e..65e89402199e642ea9bb0ac1e76674ba5fb8adb6 100644

--- a/third_party/WebKit/Source/core/frame/FrameView.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp

@@ -3635,7 +3635,8 @@ void FrameView::updateScrollOffset(const ScrollOffset& offset,

if (!scrollbarsSuppressed())

m_pendingScrollDelta += scrollDelta;

- clearFragmentAnchor();

+ if (scrollTypeClearsFragmentAnchor(scrollType))

+ clearFragmentAnchor();

updateLayersAndCompositingAfterScrollIfNeeded(scrollDelta);

Document* document = m_frame->document();