third_party/WebKit/LayoutTests/fast/loader/clamping-preserves-fragment-anchor.html - Issue 2474813002: Clamping shouldn't clear the fragment anchor.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/loader/clamping-preserves-fragment-anchor.html

Issue 2474813002: Clamping shouldn't clear the fragment anchor. (Closed)

Patch Set: add test Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <style>

	5

	6 body { height: 1400px; }

	7 body.shrink { height: 1000px; }

	8

	9 #anchor {

	10 display: block;

	11 position: absolute;

	12 width: 100px;

	13 height: 100px;

	14 background-color: #fdd;

	15 left: 200px;

	16 top: 600px;

	17 }

	18

	19 body.shrink > #anchor {

	20 top: 200px;

	21 }

	22

	23 </style>

	24 <a id="anchor" name="foo"></a>

	25 <script>

	26

	27 test(function(t) {

	28 location.hash = "#foo";

	29 assert_equals(scrollY, 600);

	30 document.body.className = "shrink";
	bokan 2016/11/03 11:19:12 This both shrinks the body and moves the <a>. Mayb This both shrinks the body and moves the <a>. Maybe split this up into two statements that explicitly shrink the body first, then move the <a> up? It'd be less dependent on the order the clamp and fragment anchoring happen. skobes 2016/11/03 13:31:42 Done. Show quoted text On 2016/11/03 11:19:12, bokan wrote: > This both shrinks the body and moves the <a>. Maybe split this up into two > statements that explicitly shrink the body first, then move the <a> up? It'd be > less dependent on the order the clamp and fragment anchoring happen. Done.
	31 assert_equals(scrollY, 200);

	32 }, "Preserve fragment anchor if clamping occurs during load.");

	33

	34 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/loader/fragment-anchor-cleared-after-load.html » ('j') | no next file with comments »