third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp - Issue 2474813002: Clamping shouldn't clear the fragment anchor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 2474813002: Clamping shouldn't clear the fragment anchor. (Closed)

Patch Set: address review comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

index b6ee0486012ccc0e828a19258a80d191c7c82a64..39c23f3675e3824ebb44b73b2a1fe389b842f207 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

@@ -454,8 +454,8 @@ void PaintLayerScrollableArea::updateScrollOffset(const ScrollOffset& newOffset,

frameView->didChangeScrollOffset();

}

- // All scrolls clear the fragment anchor.

- frameView->clearFragmentAnchor();

+ if (scrollTypeClearsFragmentAnchor(scrollType))

+ frameView->clearFragmentAnchor();

// Clear the scroll anchor, unless it is the reason for this scroll.

if (RuntimeEnabledFeatures::scrollAnchoringEnabled() &&