Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2474743002: [DevTools] migrate DOMDebugger, Input, DeviceOrientation, Tracing to new style (Closed)

Created:
4 years, 1 month ago by kozy
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, mlamouri+watch-blink_chromium.org, lushnikov+blink_chromium.org, haraken, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, timvolodine, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] migrate DOMDebugger, Input, DeviceOrientation, Tracing to new style BUG=none R=dgozman@chromium.org TBR=timvolodine@chromium.org Committed: https://crrev.com/d734c6286bb3f4cab0685c6d2a53c0ee582ebad6 Cr-Commit-Position: refs/heads/master@{#429565}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -194 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h View 2 chunks +7 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.cpp View 5 chunks +29 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h View 3 chunks +14 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 12 chunks +67 lines, -72 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInputAgent.h View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInputAgent.cpp View 3 chunks +18 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp View 2 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.h View 1 chunk +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/inspector_protocol/CodeGenerator.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/inspector_protocol/README.chromium View 1 1 chunk +3 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (11 generated)
kozy
Dmitry, please take a look!
4 years, 1 month ago (2016-11-02 18:07:46 UTC) #1
dgozman
lgtm
4 years, 1 month ago (2016-11-02 18:13:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474743002/1
4 years, 1 month ago (2016-11-02 21:12:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/60480) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, ...
4 years, 1 month ago (2016-11-02 21:16:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474743002/20001
4 years, 1 month ago (2016-11-03 04:03:28 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years, 1 month ago (2016-11-03 06:04:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474743002/20001
4 years, 1 month ago (2016-11-03 06:32:26 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years, 1 month ago (2016-11-03 08:32:59 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474743002/20001
4 years, 1 month ago (2016-11-03 13:48:29 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-03 13:54:22 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 13:57:26 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d734c6286bb3f4cab0685c6d2a53c0ee582ebad6
Cr-Commit-Position: refs/heads/master@{#429565}

Powered by Google App Engine
This is Rietveld 408576698