Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp

Issue 2474743002: [DevTools] migrate DOMDebugger, Input, DeviceOrientation, Tracing to new style (Closed)
Patch Set: rebased Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp
index 63875b2bf0945591b95883b3162992d928792fdf..1ed6b474f953eab03ffce981ddabdd20725820a0 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp
@@ -54,17 +54,16 @@ void InspectorTracingAgent::frameStoppedLoading(LocalFrame* frame) {
m_client->hideReloadingBlanket();
}
-void InspectorTracingAgent::start(
- const Maybe<String>& categories,
- const Maybe<String>& options,
- const Maybe<double>& bufferUsageReportingInterval,
- const Maybe<String>& transferMode,
- const Maybe<protocol::Tracing::TraceConfig>& config,
- std::unique_ptr<StartCallback> callback) {
+void InspectorTracingAgent::start(Maybe<String> categories,
+ Maybe<String> options,
+ Maybe<double> bufferUsageReportingInterval,
+ Maybe<String> transferMode,
+ Maybe<protocol::Tracing::TraceConfig> config,
+ std::unique_ptr<StartCallback> callback) {
DCHECK(!isStarted());
if (config.isJust()) {
- callback->sendFailure(
- "Using trace config on renderer targets is not supported yet.");
+ callback->sendFailure(Response::Error(
+ "Using trace config on renderer targets is not supported yet."));
return;
}
@@ -115,8 +114,9 @@ void InspectorTracingAgent::rootLayerCleared() {
m_client->hideReloadingBlanket();
}
-void InspectorTracingAgent::disable(ErrorString*) {
+Response InspectorTracingAgent::disable() {
innerDisable();
+ return Response::OK();
}
void InspectorTracingAgent::innerDisable() {

Powered by Google App Engine
This is Rietveld 408576698