Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2467403002: [DevTools] migrate Animation to new style (Closed)

Created:
4 years, 1 month ago by kozy
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, shans, rjwright, blink-reviews-animation_chromium.org, darktears, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kinuko+watch, Eric Willigers, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] migrate Animation to new style BUG=none R=dgozman@chromium.org Committed: https://crrev.com/a31176dcb88ec9e9464be15a65e154cd0e3f368b Cr-Commit-Position: refs/heads/master@{#429569}

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comments #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -95 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.h View 5 chunks +15 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp View 1 14 chunks +60 lines, -67 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/inspector_protocol/CodeGenerator.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/inspector_protocol/README.chromium View 1 2 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 18 (10 generated)
kozy
Dmitry, please take a look.
4 years, 1 month ago (2016-11-02 19:29:38 UTC) #1
dgozman
lgtm https://codereview.chromium.org/2467403002/diff/1/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp File third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp (right): https://codereview.chromium.org/2467403002/diff/1/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp#newcode522 third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp:522: blink::Animation* animation = m_idToAnimation.get(id); result = ...
4 years, 1 month ago (2016-11-02 23:03:22 UTC) #2
kozy
thanks! all done! https://codereview.chromium.org/2467403002/diff/1/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp File third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp (right): https://codereview.chromium.org/2467403002/diff/1/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp#newcode522 third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp:522: blink::Animation* animation = m_idToAnimation.get(id); On 2016/11/02 ...
4 years, 1 month ago (2016-11-03 01:33:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2467403002/20001
4 years, 1 month ago (2016-11-03 03:47:54 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/298723)
4 years, 1 month ago (2016-11-03 03:49:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2467403002/40001
4 years, 1 month ago (2016-11-03 13:58:06 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-03 14:03:18 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 14:05:50 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a31176dcb88ec9e9464be15a65e154cd0e3f368b
Cr-Commit-Position: refs/heads/master@{#429569}

Powered by Google App Engine
This is Rietveld 408576698