Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h

Issue 2474743002: [DevTools] migrate DOMDebugger, Input, DeviceOrientation, Tracing to new style (Closed)
Patch Set: rebased Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h
diff --git a/third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h b/third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h
index 56f921cecb7be3e7c75775407d26eb8c08cdd041..7d4f9b33bb1793bd328df2d46fda5181456d4c34 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h
+++ b/third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h
@@ -51,24 +51,21 @@ class CORE_EXPORT InspectorApplicationCacheAgent final
// InspectorBaseAgent
void restore() override;
- void disable(ErrorString*) override;
+ Response disable() override;
// InspectorInstrumentation API
void updateApplicationCacheStatus(LocalFrame*);
void networkStateChanged(LocalFrame*, bool online);
// ApplicationCache API for frontend
- void getFramesWithManifests(
- ErrorString*,
+ Response getFramesWithManifests(
std::unique_ptr<
protocol::Array<protocol::ApplicationCache::FrameWithManifest>>*
frameIds) override;
- void enable(ErrorString*) override;
- void getManifestForFrame(ErrorString*,
- const String& frameId,
- String* manifestURL) override;
- void getApplicationCacheForFrame(
- ErrorString*,
+ Response enable() override;
+ Response getManifestForFrame(const String& frameId,
+ String* manifestURL) override;
+ Response getApplicationCacheForFrame(
const String& frameId,
std::unique_ptr<protocol::ApplicationCache::ApplicationCache>*) override;
@@ -86,7 +83,7 @@ class CORE_EXPORT InspectorApplicationCacheAgent final
buildObjectForApplicationCacheResource(
const ApplicationCacheHost::ResourceInfo&);
- DocumentLoader* assertFrameWithDocumentLoader(ErrorString*, String frameId);
+ Response assertFrameWithDocumentLoader(String frameId, DocumentLoader*&);
Member<InspectedFrames> m_inspectedFrames;
};
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698