Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2473563002: [inspector] migrate Schema, Console, Profiler to new style (Closed)

Created:
4 years, 1 month ago by kozy
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] migrate Schema, Console, Profiler to new style BUG=none R=dgozman@chromium.org Committed: https://crrev.com/8c08d423f3de518a46f290067e6019e77e0a24b1 Cr-Commit-Position: refs/heads/master@{#40688}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -53 lines) Patch
M src/inspector/v8-console-agent-impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/inspector/v8-console-agent-impl.cc View 1 chunk +8 lines, -7 lines 0 comments Download
M src/inspector/v8-inspector-session-impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/inspector/v8-profiler-agent-impl.h View 2 chunks +6 lines, -7 lines 0 comments Download
M src/inspector/v8-profiler-agent-impl.cc View 2 chunks +21 lines, -26 lines 0 comments Download
M src/inspector/v8-schema-agent-impl.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/inspector/v8-schema-agent-impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/inspector_protocol/CodeGenerator.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/inspector_protocol/README.v8 View 1 chunk +3 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
kozy
Dmitry, please take a look.
4 years, 1 month ago (2016-11-01 21:28:53 UTC) #1
dgozman
lgtm
4 years, 1 month ago (2016-11-01 21:42:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2473563002/1
4 years, 1 month ago (2016-11-01 22:40:03 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/11272) v8_linux_arm_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 1 month ago (2016-11-01 22:54:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2473563002/1
4 years, 1 month ago (2016-11-01 23:33:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 00:21:38 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:18:50 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c08d423f3de518a46f290067e6019e77e0a24b1
Cr-Commit-Position: refs/heads/master@{#40688}

Powered by Google App Engine
This is Rietveld 408576698