Chromium Code Reviews

Issue 2469063002: Roll third_party/inspector_protocol to cf45a6e89b17cdc9eeacdef4c003fcc55f7ec2a0 (Closed)

Created:
4 years, 1 month ago by kozy
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Roll third_party/inspector_protocol to cf45a6e89b17cdc9eeacdef4c003fcc55f7ec2a0 This roll includes one change: "[inspector_protocol] support fall through and moveable Maybe" [1]. [1] https://codereview.chromium.org/2468923002/ BUG=none R=dgozman@chromium.org Committed: https://crrev.com/d5055bc932107243fa29c70a27fcf48ea6d29fb8 Cr-Commit-Position: refs/heads/master@{#40687}

Patch Set 1 #

Patch Set 2 : rebased test #

Unified diffs Side-by-side diffs Stats (+267 lines, -129 lines)
M test/inspector/debugger/set-breakpoint-before-enabling-expected.txt View 1 chunk +1 line, -2 lines 0 comments
M third_party/inspector_protocol/CodeGenerator.py View 4 chunks +7 lines, -2 lines 0 comments
M third_party/inspector_protocol/README.v8 View 1 chunk +1 line, -1 line 0 comments
M third_party/inspector_protocol/inspector_protocol.gni View 1 chunk +0 lines, -1 line 0 comments
M third_party/inspector_protocol/inspector_protocol.gypi View 1 chunk +0 lines, -1 line 0 comments
D third_party/inspector_protocol/lib/BackendCallback_h.template View 1 chunk +0 lines, -24 lines 0 comments
M third_party/inspector_protocol/lib/DispatcherBase_cpp.template View 6 chunks +82 lines, -30 lines 0 comments
M third_party/inspector_protocol/lib/DispatcherBase_h.template View 5 chunks +42 lines, -19 lines 0 comments
M third_party/inspector_protocol/lib/Forward_h.template View 1 chunk +2 lines, -0 lines 0 comments
M third_party/inspector_protocol/lib/Maybe_h.template View 6 chunks +6 lines, -0 lines 0 comments
M third_party/inspector_protocol/templates/TypeBuilder_cpp.template View 7 chunks +71 lines, -34 lines 0 comments
M third_party/inspector_protocol/templates/TypeBuilder_h.template View 3 chunks +55 lines, -15 lines 0 comments

Messages

Total messages: 16 (9 generated)
kozy
Dmitry, please take a look.
4 years, 1 month ago (2016-11-01 20:09:04 UTC) #1
dgozman
rs lgtm
4 years, 1 month ago (2016-11-01 21:36:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2469063002/1
4 years, 1 month ago (2016-11-01 21:48:00 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/builds/11640) v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 1 month ago (2016-11-01 22:04:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2469063002/2
4 years, 1 month ago (2016-11-01 22:08:35 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:2)
4 years, 1 month ago (2016-11-01 22:33:12 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:18:48 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d5055bc932107243fa29c70a27fcf48ea6d29fb8
Cr-Commit-Position: refs/heads/master@{#40687}

Powered by Google App Engine