Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: src/inspector/v8-profiler-agent-impl.h

Issue 2473563002: [inspector] migrate Schema, Console, Profiler to new style (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/inspector/v8-inspector-session-impl.cc ('k') | src/inspector/v8-profiler-agent-impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/v8-profiler-agent-impl.h
diff --git a/src/inspector/v8-profiler-agent-impl.h b/src/inspector/v8-profiler-agent-impl.h
index ee8997653af5183b50c05f425a3c8c0f0b7435a2..a634ff3cd9f5eebe9a3bbfb93442f90cb8d41ef1 100644
--- a/src/inspector/v8-profiler-agent-impl.h
+++ b/src/inspector/v8-profiler-agent-impl.h
@@ -20,7 +20,7 @@ namespace v8_inspector {
class V8InspectorSessionImpl;
-using protocol::ErrorString;
+using protocol::Response;
class V8ProfilerAgentImpl : public protocol::Profiler::Backend {
public:
@@ -31,12 +31,11 @@ class V8ProfilerAgentImpl : public protocol::Profiler::Backend {
bool enabled() const { return m_enabled; }
void restore();
- void enable(ErrorString*) override;
- void disable(ErrorString*) override;
- void setSamplingInterval(ErrorString*, int) override;
- void start(ErrorString*) override;
- void stop(ErrorString*,
- std::unique_ptr<protocol::Profiler::Profile>*) override;
+ Response enable() override;
+ Response disable() override;
+ Response setSamplingInterval(int) override;
+ Response start() override;
+ Response stop(std::unique_ptr<protocol::Profiler::Profile>*) override;
void consoleProfile(const String16& title);
void consoleProfileEnd(const String16& title);
« no previous file with comments | « src/inspector/v8-inspector-session-impl.cc ('k') | src/inspector/v8-profiler-agent-impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698