Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2474483003: [inspector] migrate HeapProfiler to new style (Closed)

Created:
4 years, 1 month ago by kozy
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] migrate HeapProfiler to new style BUG=none R=dgozman@chromium.org Committed: https://crrev.com/39020433246e4e5e479345bce73207b13ed6738e Cr-Commit-Position: refs/heads/master@{#40689}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -98 lines) Patch
M src/inspector/v8-heap-profiler-agent-impl.h View 2 chunks +16 lines, -22 lines 0 comments Download
M src/inspector/v8-heap-profiler-agent-impl.cc View 7 chunks +48 lines, -72 lines 0 comments Download
M src/inspector/v8-inspector-session-impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/inspector_protocol/CodeGenerator.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/inspector_protocol/README.v8 View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
kozy
Dmitry, please take a look.
4 years, 1 month ago (2016-11-01 21:54:16 UTC) #1
dgozman
lgtm
4 years, 1 month ago (2016-11-01 22:11:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474483003/1
4 years, 1 month ago (2016-11-02 00:26:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 00:51:50 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:18:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/39020433246e4e5e479345bce73207b13ed6738e
Cr-Commit-Position: refs/heads/master@{#40689}

Powered by Google App Engine
This is Rietveld 408576698