[Sync] Improve MetadataChangeList usage for types using ModelTypeStore.

[Sync] Improve MetadataChangeList usage for types using ModelTypeStore.

- Added WriteBatch::CreateMetadataChangeList() and
  WriteBatch::GetMetadataChangeList().
- Split off InMemoryMetadataChangeList from SimpleMCL to be a new base
  class for MCLs that store things in memory.
- Split off AccumulatingMetadataChangeList from SimpleMCL.
- Move SimpleMCL inside FakeModelTypeSyncBridge as
  TestMetadataChangeList.

BUG=661260
Committed: https://crrev.com/73b065e269ab993b5ffcb2d88344b8754894b05c
Cr-Commit-Position: refs/heads/master@{#429749}

[maxbogue, 2016-11-03 03:45:41]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 03:46:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maxbogue, 2016-11-03 03:47:09]

Description was changed from

==========
Demo of suggested MetadataChangeList usage.

BUG=
==========

to

==========
[Sync] Improve MetadataChangeList usage for types using ModelTypeStore.

- Added WriteBatch::CreateMetadataChangeList() and
  WriteBatch::GetMetadataChangeList().
- Split off InMemoryMetadataChangeList from SimpleMCL to be a new base
  class for MCLs that store things in memory.
- Split off AccumulatingMetadataChangeList from SimpleMCL.
- Move SimpleMCL inside FakeModelTypeSyncBridge as
  TestMetadataChangeList.

BUG=661260
==========

[maxbogue, 2016-11-03 03:47:36]

maxbogue@chromium.org changed reviewers:
+ pavely@chromium.org, skym@chromium.org

[maxbogue, 2016-11-03 03:47:37]

Sky, Pavel, PTAL!

[commit-bot: I haz the power, 2016-11-03 05:46:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 05:46:45]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[skym, 2016-11-03 15:46:28]

lgtm

https://codereview.chromium.org/2473553003/diff/20001/components/sync/model_i...
File components/sync/model_impl/in_memory_metadata_change_list.h (right):

https://codereview.chromium.org/2473553003/diff/20001/components/sync/model_i...
components/sync/model_impl/in_memory_metadata_change_list.h:20: // fields, with
accessors for inspecting them.
As you pointed out to me, there are not accessors.

[maxbogue, 2016-11-03 19:05:23]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 19:06:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maxbogue, 2016-11-03 19:06:23]

https://codereview.chromium.org/2473553003/diff/20001/components/sync/model_i...
File components/sync/model_impl/in_memory_metadata_change_list.h (right):

https://codereview.chromium.org/2473553003/diff/20001/components/sync/model_i...
components/sync/model_impl/in_memory_metadata_change_list.h:20: // fields, with
accessors for inspecting them.
On 2016/11/03 15:46:28, skym wrote:
> As you pointed out to me, there are not accessors.

Done.

[maxbogue, 2016-11-03 19:16:27]

The CQ bit was unchecked by maxbogue@chromium.org

[maxbogue, 2016-11-03 19:16:31]

The CQ bit was checked by maxbogue@chromium.org

[maxbogue, 2016-11-03 19:16:31]

The patchset sent to the CQ was uploaded after l-g-t-m from skym@chromium.org
Link to the patchset: https://codereview.chromium.org/2473553003/#ps40001
(title: "Fix comments + protected constructor.")

[commit-bot: I haz the power, 2016-11-03 19:17:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 20:07:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 20:07:20]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[maxbogue, 2016-11-03 20:09:36]

The CQ bit was checked by maxbogue@chromium.org

[commit-bot: I haz the power, 2016-11-03 20:10:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 22:47:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 22:47:34]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[maxbogue, 2016-11-03 22:48:12]

The CQ bit was checked by maxbogue@chromium.org

[commit-bot: I haz the power, 2016-11-03 22:49:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 01:08:30]

Description was changed from

==========
[Sync] Improve MetadataChangeList usage for types using ModelTypeStore.

- Added WriteBatch::CreateMetadataChangeList() and
  WriteBatch::GetMetadataChangeList().
- Split off InMemoryMetadataChangeList from SimpleMCL to be a new base
  class for MCLs that store things in memory.
- Split off AccumulatingMetadataChangeList from SimpleMCL.
- Move SimpleMCL inside FakeModelTypeSyncBridge as
  TestMetadataChangeList.

BUG=661260
==========

to

==========
[Sync] Improve MetadataChangeList usage for types using ModelTypeStore.

- Added WriteBatch::CreateMetadataChangeList() and
  WriteBatch::GetMetadataChangeList().
- Split off InMemoryMetadataChangeList from SimpleMCL to be a new base
  class for MCLs that store things in memory.
- Split off AccumulatingMetadataChangeList from SimpleMCL.
- Move SimpleMCL inside FakeModelTypeSyncBridge as
  TestMetadataChangeList.

BUG=661260
==========

[commit-bot: I haz the power, 2016-11-04 01:08:35]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-04 01:10:33]

Description was changed from

==========
[Sync] Improve MetadataChangeList usage for types using ModelTypeStore.

- Added WriteBatch::CreateMetadataChangeList() and
  WriteBatch::GetMetadataChangeList().
- Split off InMemoryMetadataChangeList from SimpleMCL to be a new base
  class for MCLs that store things in memory.
- Split off AccumulatingMetadataChangeList from SimpleMCL.
- Move SimpleMCL inside FakeModelTypeSyncBridge as
  TestMetadataChangeList.

BUG=661260
==========

to

==========
[Sync] Improve MetadataChangeList usage for types using ModelTypeStore.

- Added WriteBatch::CreateMetadataChangeList() and
  WriteBatch::GetMetadataChangeList().
- Split off InMemoryMetadataChangeList from SimpleMCL to be a new base
  class for MCLs that store things in memory.
- Split off AccumulatingMetadataChangeList from SimpleMCL.
- Move SimpleMCL inside FakeModelTypeSyncBridge as
  TestMetadataChangeList.

BUG=661260

Committed: https://crrev.com/73b065e269ab993b5ffcb2d88344b8754894b05c
Cr-Commit-Position: refs/heads/master@{#429749}
==========

[commit-bot: I haz the power, 2016-11-04 01:10:34]

Patchset 3 (id:??) landed as
https://crrev.com/73b065e269ab993b5ffcb2d88344b8754894b05c
Cr-Commit-Position: refs/heads/master@{#429749}