components/sync/model_impl/model_type_store_impl.h - Issue 2473553003: [Sync] Improve MetadataChangeList usage for types using ModelTypeStore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/model_impl/model_type_store_impl.h

Issue 2473553003: [Sync] Improve MetadataChangeList usage for types using ModelTypeStore. (Closed)

Patch Set: Fix comments + protected constructor. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/model_impl/model_type_store_impl.h

diff --git a/components/sync/model_impl/model_type_store_impl.h b/components/sync/model_impl/model_type_store_impl.h

index 5a7d1d59a1b57a89c9eed12db88a8a75af6881c4..b8fa0b73811485e1fcf72aca595f3ee18773240f 100644

--- a/components/sync/model_impl/model_type_store_impl.h

+++ b/components/sync/model_impl/model_type_store_impl.h

@@ -60,7 +60,7 @@ class ModelTypeStoreImpl : public ModelTypeStore, public base::NonThreadSafe {

private:

class WriteBatchImpl : public WriteBatch {

public:

- WriteBatchImpl();

+ explicit WriteBatchImpl(ModelTypeStore* store);

~WriteBatchImpl() override;

std::unique_ptr<leveldb::WriteBatch> leveldb_write_batch_;

};