components/sync/model/mock_model_type_store.cc - Issue 2473553003: [Sync] Improve MetadataChangeList usage for types using ModelTypeStore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/model/mock_model_type_store.cc

Issue 2473553003: [Sync] Improve MetadataChangeList usage for types using ModelTypeStore. (Closed)

Patch Set: Fix comments + protected constructor. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/model/mock_model_type_store.cc

diff --git a/components/sync/model/mock_model_type_store.cc b/components/sync/model/mock_model_type_store.cc

index 685ee079bee81672af82f78cef8a0c514baf25d2..ac2a9d272590204e83c5ea225f98337ced47b191 100644

--- a/components/sync/model/mock_model_type_store.cc

+++ b/components/sync/model/mock_model_type_store.cc

@@ -54,7 +54,7 @@ void MockModelTypeStore::ReadAllMetadata(const ReadMetadataCallback& callback) {

std::unique_ptr<MockModelTypeStore::WriteBatch>

MockModelTypeStore::CreateWriteBatch() {

- return base::WrapUnique(new MockModelTypeStore::WriteBatch());

+ return base::WrapUnique(new MockModelTypeStore::WriteBatch(this));

}

void MockModelTypeStore::CommitWriteBatch(