Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2473103005: Application group identifier should respect ios_app_bundle_id_prefix. (Closed)

Created:
4 years, 1 month ago by sdefresne
Modified:
4 years, 1 month ago
Reviewers:
Olivier
CC:
chromium-reviews, mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Application group identifier should respect ios_app_bundle_id_prefix. BUG=613543 Committed: https://crrev.com/2168ba09b54ace301266f28072ce962982a4541d Cr-Commit-Position: refs/heads/master@{#430552}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M ios/chrome/common/app_group/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M ios/chrome/common/app_group/app_group_constants.mm View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (8 generated)
sdefresne
Please take a look and send to CQ if LGTY.
4 years, 1 month ago (2016-11-04 14:10:31 UTC) #4
Olivier
lgtm
4 years, 1 month ago (2016-11-04 14:21:38 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 2475893002 Patch 1). Please resolve the dependency and ...
4 years, 1 month ago (2016-11-04 14:23:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2473103005/1
4 years, 1 month ago (2016-11-08 08:22:06 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 09:10:19 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 09:19:12 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2168ba09b54ace301266f28072ce962982a4541d
Cr-Commit-Position: refs/heads/master@{#430552}

Powered by Google App Engine
This is Rietveld 408576698