Rename XCTests test main target and output.

Rename XCTests test main target and output.

Refactor ios_xctest_test template in order to have the main target
correspond to the host application and to have the dynamic module
be a secondary target.

With this change ios_xctest_test("foo") { ... } will now create an
application named foo.app (instead of foo_host.app) and the target
will be correctly named foo (instead of foo_host).

Keep the old target foo_host and the foo_host.app as compatibility
until the downstream bots have been fixed to use the new names.

Rename ios_web_shell_test_host to ios_web_shell_egtests.

BUG=662404
Committed: https://crrev.com/103ee1e345eb36725297bb35e758cbbd023cb8a8
Cr-Commit-Position: refs/heads/master@{#430570}

[sdefresne, 2016-11-04 15:14:04]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2016-11-04 15:14:22]

sdefresne@chromium.org changed reviewers:
+ baxley@chromium.org

[sdefresne, 2016-11-04 15:14:22]

Please take a look.

[commit-bot: I haz the power, 2016-11-04 15:14:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[baxley, 2016-11-04 15:26:19]

baxley@chromium.org changed reviewers:
+ baxley@chromium.org

[baxley, 2016-11-04 15:26:20]

LGTM

I think the target should ultimately end in an 's' (ios_web_shell_eg_tests, like
in the other CL). I can do cleanup later, so you don't have to do more on this,
since you have to do enough orchestrating between downstream and upstream to
make this work. Thanks!

https://codereview.chromium.org/2473103006/diff/1/build/config/ios/rules.gni
File build/config/ios/rules.gni (right):

https://codereview.chromium.org/2473103006/diff/1/build/config/ios/rules.gni#...
build/config/ios/rules.gni:1365: ":${_host_target}_host",
this will also go away as part of crbug.com/662404 when downstream is updated?

[sdefresne, 2016-11-04 15:55:15]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 15:55:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-11-04 15:57:26]

sdefresne@chromium.org changed reviewers:
+ smut@google.com

[sdefresne, 2016-11-04 15:57:26]

Mike: please take another look as I improved the template and renamed the
target.

Sana: can you review ios/build/bots/scripts/test_runner.py as OWNERS?

https://codereview.chromium.org/2473103006/diff/1/build/config/ios/rules.gni
File build/config/ios/rules.gni (right):

https://codereview.chromium.org/2473103006/diff/1/build/config/ios/rules.gni#...
build/config/ios/rules.gni:1365: ":${_host_target}_host",
On 2016/11/04 15:26:20, baxley wrote:
> this will also go away as part of crbug.com/662404 when downstream is updated?

The answer would have been yes, but I tweaked the template to use a boolean
parameter (undocumented because transient) to select the naming convention. This
avoid building the app two times and avoid breaking launching them in Xcode.

I've put TODO around all code that should be removed once the downstream repo
has been fixed to use the new names.

[sdefresne, 2016-11-04 15:58:52]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 15:59:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-11-04 16:04:35]

Description was changed from

==========
Rename XCTests test main target and output.

Refactor ios_xctest_test template in order to have the main target
correspond to the host application and to have the dynamic module
be a secondary target.

With this change ios_xctest_test("foo") { ... } will now create an
application named foo.app (instead of foo_host.app) and the target
will be correctly named foo (instead of foo_host).

Keep the old target foo_host and the foo_host.app as compatibility
until the downstream bots have been fixed to use the new names.

BUG=662404
==========

to

==========
Rename XCTests test main target and output.

Refactor ios_xctest_test template in order to have the main target
correspond to the host application and to have the dynamic module
be a secondary target.

With this change ios_xctest_test("foo") { ... } will now create an
application named foo.app (instead of foo_host.app) and the target
will be correctly named foo (instead of foo_host).

Keep the old target foo_host and the foo_host.app as compatibility
until the downstream bots have been fixed to use the new names.

Rename ios_web_shell_test_host to ios_web_shell_egtests.

BUG=662404
==========

[baxley, 2016-11-04 16:36:53]

LGTM, I think it looks cleaner.

Regarding names, I don't know if we want to prefix all integration test suites
with ios/ios_internal? I see how this is consistent with some things. However I
don't think we need to have that discussion now, we can focus on removing _host
here (in other words, I'm fine with your naming). Thanks!

[commit-bot: I haz the power, 2016-11-04 17:08:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 17:08:28]

Dry run: This issue passed the CQ dry run.

[smut, 2016-11-04 21:11:44]

On 2016/11/04 16:36:53, baxley wrote:
> LGTM, I think it looks cleaner.
> 
> Regarding names, I don't know if we want to prefix all integration test suites
> with ios/ios_internal? I see how this is consistent with some things. However
I
> don't think we need to have that discussion now, we can focus on removing
_host
> here (in other words, I'm fine with your naming). Thanks!

How does this affect the test runner?
https://chromium.googlesource.com/chromium/src/+/master/ios/build/bots/script...

Note that green CQ will not tell you if the test runner works for EarlGrey
because EG tests run only on FYI, not on CQ.

[sdefresne, 2016-11-07 08:38:06]

On 2016/11/04 21:11:44, smut wrote:
> On 2016/11/04 16:36:53, baxley wrote:
> > LGTM, I think it looks cleaner.
> > 
> > Regarding names, I don't know if we want to prefix all integration test
suites
> > with ios/ios_internal? I see how this is consistent with some things.
However
> I
> > don't think we need to have that discussion now, we can focus on removing
> _host
> > here (in other words, I'm fine with your naming). Thanks!
> 
> How does this affect the test runner?
>
https://chromium.googlesource.com/chromium/src/+/master/ios/build/bots/script...
> 
> Note that green CQ will not tell you if the test runner works for EarlGrey
> because EG tests run only on FYI, not on CQ.

I've created multiple CLs to allow the test runner to support both old and new
convention:
https://codereview.chromium.org/2473103006/
https://chromereviews.googleplex.com/538827013/

I also change ios/build/bots/scripts/test_runner.py here. Did I miss some place?
I think that my changes allow the test runner to support either old or new
names.

PTAL

[smut, 2016-11-07 20:51:26]

On 2016/11/07 08:38:06, sdefresne wrote:
> On 2016/11/04 21:11:44, smut wrote:
> > On 2016/11/04 16:36:53, baxley wrote:
> > > LGTM, I think it looks cleaner.
> > > 
> > > Regarding names, I don't know if we want to prefix all integration test
> suites
> > > with ios/ios_internal? I see how this is consistent with some things.
> However
> > I
> > > don't think we need to have that discussion now, we can focus on removing
> > _host
> > > here (in other words, I'm fine with your naming). Thanks!
> > 
> > How does this affect the test runner?
> >
>
https://chromium.googlesource.com/chromium/src/+/master/ios/build/bots/script...
> > 
> > Note that green CQ will not tell you if the test runner works for EarlGrey
> > because EG tests run only on FYI, not on CQ.
> 
> I've created multiple CLs to allow the test runner to support both old and new
> convention:
> https://codereview.chromium.org/2473103006/
> https://chromereviews.googleplex.com/538827013/
> 
> I also change ios/build/bots/scripts/test_runner.py here. Did I miss some
place?
> I think that my changes allow the test runner to support either old or new
> names.
> 
> PTAL

Sorry, I didn't see that you changed it. Lgtm.

[smut, 2016-11-07 20:51:35]

The CQ bit was checked by smut@google.com

[commit-bot: I haz the power, 2016-11-07 20:51:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 20:51:57]

This CL has an open dependency (Issue 2473103005 Patch 1). Please resolve the
dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[sdefresne, 2016-11-08 09:37:23]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2016-11-08 09:37:24]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-11-08 09:37:25]

The patchset sent to the CQ was uploaded after l-g-t-m from baxley@chromium.org,
smut@google.com
Link to the patchset: https://codereview.chromium.org/2473103006/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-11-08 09:37:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 10:39:04]

Description was changed from

==========
Rename XCTests test main target and output.

Refactor ios_xctest_test template in order to have the main target
correspond to the host application and to have the dynamic module
be a secondary target.

With this change ios_xctest_test("foo") { ... } will now create an
application named foo.app (instead of foo_host.app) and the target
will be correctly named foo (instead of foo_host).

Keep the old target foo_host and the foo_host.app as compatibility
until the downstream bots have been fixed to use the new names.

Rename ios_web_shell_test_host to ios_web_shell_egtests.

BUG=662404
==========

to

==========
Rename XCTests test main target and output.

Refactor ios_xctest_test template in order to have the main target
correspond to the host application and to have the dynamic module
be a secondary target.

With this change ios_xctest_test("foo") { ... } will now create an
application named foo.app (instead of foo_host.app) and the target
will be correctly named foo (instead of foo_host).

Keep the old target foo_host and the foo_host.app as compatibility
until the downstream bots have been fixed to use the new names.

Rename ios_web_shell_test_host to ios_web_shell_egtests.

BUG=662404
==========

[commit-bot: I haz the power, 2016-11-08 10:39:05]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-08 10:41:56]

Description was changed from

==========
Rename XCTests test main target and output.

Refactor ios_xctest_test template in order to have the main target
correspond to the host application and to have the dynamic module
be a secondary target.

With this change ios_xctest_test("foo") { ... } will now create an
application named foo.app (instead of foo_host.app) and the target
will be correctly named foo (instead of foo_host).

Keep the old target foo_host and the foo_host.app as compatibility
until the downstream bots have been fixed to use the new names.

Rename ios_web_shell_test_host to ios_web_shell_egtests.

BUG=662404
==========

to

==========
Rename XCTests test main target and output.

Refactor ios_xctest_test template in order to have the main target
correspond to the host application and to have the dynamic module
be a secondary target.

With this change ios_xctest_test("foo") { ... } will now create an
application named foo.app (instead of foo_host.app) and the target
will be correctly named foo (instead of foo_host).

Keep the old target foo_host and the foo_host.app as compatibility
until the downstream bots have been fixed to use the new names.

Rename ios_web_shell_test_host to ios_web_shell_egtests.

BUG=662404

Committed: https://crrev.com/103ee1e345eb36725297bb35e758cbbd023cb8a8
Cr-Commit-Position: refs/heads/master@{#430570}
==========

[commit-bot: I haz the power, 2016-11-08 10:41:57]

Patchset 4 (id:??) landed as
https://crrev.com/103ee1e345eb36725297bb35e758cbbd023cb8a8
Cr-Commit-Position: refs/heads/master@{#430570}