Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Side by Side Diff: ios/chrome/common/app_group/BUILD.gn

Issue 2473103005: Application group identifier should respect ios_app_bundle_id_prefix. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ios/chrome/common/app_group/app_group_constants.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/ios/ios_sdk.gni")
6
5 source_set("app_group") { 7 source_set("app_group") {
6 sources = [ 8 sources = [
7 "app_group_constants.h", 9 "app_group_constants.h",
8 "app_group_constants.mm", 10 "app_group_constants.mm",
9 "app_group_metrics.h", 11 "app_group_metrics.h",
10 "app_group_metrics.mm", 12 "app_group_metrics.mm",
11 ] 13 ]
12 14
13 deps = [ 15 deps = [
14 "//base", 16 "//base",
15 "//components/version_info", 17 "//components/version_info",
16 ] 18 ]
19
20 defines = [ "IOS_BUNDLE_ID_PREFIX=\"$ios_app_bundle_id_prefix\"" ]
17 } 21 }
18 22
19 # This target will be included into application extensions and the list 23 # This target will be included into application extensions and the list
20 # of its dependencies must be kept as short as possible. 24 # of its dependencies must be kept as short as possible.
21 source_set("client") { 25 source_set("client") {
22 sources = [ 26 sources = [
23 "app_group_metrics_client.h", 27 "app_group_metrics_client.h",
24 "app_group_metrics_client.mm", 28 "app_group_metrics_client.mm",
25 ] 29 ]
26 30
27 deps = [ 31 deps = [
28 ":app_group", 32 ":app_group",
29 "//base", 33 "//base",
30 ] 34 ]
31 } 35 }
32 36
33 source_set("main_app") { 37 source_set("main_app") {
34 sources = [ 38 sources = [
35 "app_group_metrics_mainapp.h", 39 "app_group_metrics_mainapp.h",
36 "app_group_metrics_mainapp.mm", 40 "app_group_metrics_mainapp.mm",
37 ] 41 ]
38 42
39 deps = [ 43 deps = [
40 ":app_group", 44 ":app_group",
41 "//base", 45 "//base",
42 ] 46 ]
43 } 47 }
OLDNEW
« no previous file with comments | « no previous file | ios/chrome/common/app_group/app_group_constants.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698