Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2475893002: Add template to compile plist files. (Closed)

Created:
4 years, 1 month ago by sdefresne
Modified:
4 years, 1 month ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add template to compile plist files. Add new template compile_plist that merge multiple plist files and perform variables subsitutions and change info_plist implementation to use it. The new template will be used to compile entitlements files that need different substitutions and do not use the one for Info.plist. BUG=613543 Committed: https://crrev.com/7a7cd719032f146447c5b41ee6e243648ec0d397 Cr-Commit-Position: refs/heads/master@{#430269}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -38 lines) Patch
M build/config/mac/base_rules.gni View 3 chunks +81 lines, -38 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (9 generated)
sdefresne
Please take a look and send to CQ if LGTY.
4 years, 1 month ago (2016-11-04 10:13:47 UTC) #4
Robert Sesek
lgtm
4 years, 1 month ago (2016-11-04 16:42:18 UTC) #8
commit-bot: I haz the power
This CL has an open dependency (Issue 2473483011 Patch 1). Please resolve the dependency and ...
4 years, 1 month ago (2016-11-04 16:43:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2475893002/1
4 years, 1 month ago (2016-11-07 13:39:44 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 14:40:34 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 14:42:43 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a7cd719032f146447c5b41ee6e243648ec0d397
Cr-Commit-Position: refs/heads/master@{#430269}

Powered by Google App Engine
This is Rietveld 408576698