Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 247143004: cleanup: Cpplint for apps/, extensions/ (Closed)

Created:
6 years, 8 months ago by limasdf
Modified:
6 years, 8 months ago
Reviewers:
benwells
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Cpplint for apps/, extensions/ BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265884

Patch Set 1 #

Patch Set 2 : CHECK_GT -> CHECK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -40 lines) Patch
M apps/app_shim/app_shim_host_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
M apps/app_shim/app_shim_host_manager_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
M apps/app_shim/extension_app_shim_handler_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
M apps/app_window.cc View 1 chunk +0 lines, -1 line 0 comments Download
M apps/app_window_contents.h View 2 chunks +3 lines, -3 lines 0 comments Download
M apps/app_window_geometry_cache.h View 1 chunk +1 line, -1 line 0 comments Download
M apps/app_window_geometry_cache.cc View 1 chunk +0 lines, -1 line 0 comments Download
M apps/app_window_geometry_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M apps/app_window_registry.h View 1 chunk +1 line, -1 line 0 comments Download
M apps/app_window_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M apps/browser_context_keyed_service_factories.h View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/admin_policy.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/browser_context_keyed_service_factories.h View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/extension_error.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/extension_error_test_util.cc View 1 chunk +10 lines, -9 lines 0 comments Download
M extensions/browser/extension_message_filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/extension_prefs.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/extension_prefs.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
limasdf
TPAL. this is almost mechanical change.
6 years, 8 months ago (2014-04-22 18:37:42 UTC) #1
benwells
lgtm
6 years, 8 months ago (2014-04-24 01:23:03 UTC) #2
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 8 months ago (2014-04-24 01:24:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/247143004/1
6 years, 8 months ago (2014-04-24 02:05:16 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 03:57:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-24 03:57:33 UTC) #6
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 8 months ago (2014-04-24 04:28:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/247143004/20001
6 years, 8 months ago (2014-04-24 04:52:49 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 08:34:08 UTC) #9
Message was sent while issue was closed. 
Change committed as 265884

Powered by Google App Engine
This is Rietveld 408576698