apps/app_window_geometry_cache_unittest.cc - Issue 247143004: cleanup: Cpplint for apps/, extensions/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: apps/app_window_geometry_cache_unittest.cc

Issue 247143004: cleanup: Cpplint for apps/, extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CHECK_GT -> CHECK Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « apps/app_window_geometry_cache.cc ('k') | apps/app_window_registry.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "apps/app_window_geometry_cache.h"	5 #include "apps/app_window_geometry_cache.h"

6 #include "base/memory/scoped_ptr.h"	6 #include "base/memory/scoped_ptr.h"

7 #include "base/prefs/mock_pref_change_callback.h"	7 #include "base/prefs/mock_pref_change_callback.h"

8 #include "base/strings/string_number_conversions.h"	8 #include "base/strings/string_number_conversions.h"

9 #include "chrome/browser/extensions/test_extension_prefs.h"	9 #include "chrome/browser/extensions/test_extension_prefs.h"

10 #include "chrome/test/base/testing_profile.h"	10 #include "chrome/test/base/testing_profile.h"

(...skipping 324 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
335	335

336 // The first added window should no longer have cached geometry.	336 // The first added window should no longer have cached geometry.

337 EXPECT_FALSE(cache_->GetGeometry(extension_id, "window_0", NULL, NULL, NULL));	337 EXPECT_FALSE(cache_->GetGeometry(extension_id, "window_0", NULL, NULL, NULL));

338 // All other windows should still exist.	338 // All other windows should still exist.

339 for (size_t i = 1; i < AppWindowGeometryCache::kMaxCachedWindows + 1; ++i) {	339 for (size_t i = 1; i < AppWindowGeometryCache::kMaxCachedWindows + 1; ++i) {

340 std::string window_id = "window_" + base::IntToString(i);	340 std::string window_id = "window_" + base::IntToString(i);

341 EXPECT_TRUE(cache_->GetGeometry(extension_id, window_id, NULL, NULL, NULL));	341 EXPECT_TRUE(cache_->GetGeometry(extension_id, window_id, NULL, NULL, NULL));

342 }	342 }

343 }	343 }

344	344

345 } // namespace extensions	345 } // namespace apps

OLD	NEW