Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: extensions/browser/extension_error_test_util.cc

Issue 247143004: cleanup: Cpplint for apps/, extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CHECK_GT -> CHECK Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/browser/extension_error.h ('k') | extensions/browser/extension_message_filter.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/extension_error_test_util.h" 5 #include "extensions/browser/extension_error_test_util.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/strings/string_util.h" 8 #include "base/strings/string_util.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "content/public/common/url_constants.h" 10 #include "content/public/common/url_constants.h"
(...skipping 17 matching lines...) Expand all
28 scoped_ptr<StackFrame> frame = 28 scoped_ptr<StackFrame> frame =
29 StackFrame::CreateFromText(base::UTF8ToUTF16(kDefaultStackTrace)); 29 StackFrame::CreateFromText(base::UTF8ToUTF16(kDefaultStackTrace));
30 CHECK(frame.get()); 30 CHECK(frame.get());
31 stack_trace.push_back(*frame); 31 stack_trace.push_back(*frame);
32 32
33 base::string16 source = 33 base::string16 source =
34 base::UTF8ToUTF16(std::string(kExtensionScheme) + 34 base::UTF8ToUTF16(std::string(kExtensionScheme) +
35 content::kStandardSchemeSeparator + 35 content::kStandardSchemeSeparator +
36 extension_id); 36 extension_id);
37 37
38 return scoped_ptr<ExtensionError>(new RuntimeError( 38 return scoped_ptr<ExtensionError>(
39 extension_id, 39 new RuntimeError(extension_id,
40 from_incognito, 40 from_incognito,
41 source, 41 source,
42 base::UTF8ToUTF16(message), 42 base::UTF8ToUTF16(message),
43 stack_trace, 43 stack_trace,
44 GURL::EmptyGURL(), // no context url 44 GURL::EmptyGURL(), // no context url
45 logging::LOG_INFO, 45 logging::LOG_INFO,
46 0, 0 /* Render [View|Process] ID */ )); 46 0,
47 0 /* Render [View|Process] ID */));
47 } 48 }
48 49
49 scoped_ptr<ExtensionError> CreateNewRuntimeError( 50 scoped_ptr<ExtensionError> CreateNewRuntimeError(
50 const std::string& extension_id, const std::string& message) { 51 const std::string& extension_id, const std::string& message) {
51 return CreateNewRuntimeError(extension_id, message, false); 52 return CreateNewRuntimeError(extension_id, message, false);
52 } 53 }
53 54
54 scoped_ptr<ExtensionError> CreateNewManifestError( 55 scoped_ptr<ExtensionError> CreateNewManifestError(
55 const std::string& extension_id, const std::string& message) { 56 const std::string& extension_id, const std::string& message) {
56 return scoped_ptr<ExtensionError>( 57 return scoped_ptr<ExtensionError>(
57 new ManifestError(extension_id, 58 new ManifestError(extension_id,
58 base::UTF8ToUTF16(message), 59 base::UTF8ToUTF16(message),
59 base::EmptyString16(), 60 base::EmptyString16(),
60 base::EmptyString16())); 61 base::EmptyString16()));
61 } 62 }
62 63
63 } // namespace error_test_util 64 } // namespace error_test_util
64 } // namespace extensions 65 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/browser/extension_error.h ('k') | extensions/browser/extension_message_filter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698