Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2470453002: Add Linux Ozone fyi compile-only bot (src-side changes) (Closed)

Created:
4 years, 1 month ago by Tom (Use chromium acct)
Modified:
4 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Linux Ozone fyi compile-only bot (src-side changes) BUG=295089 R=dpranke@chromium.org Committed: https://crrev.com/a4772dcd8400da7137c37e9590acdadba1306783 Cr-Commit-Position: refs/heads/master@{#428912}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M tools/mb/mb_config.pyl View 1 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Tom (Use chromium acct)
dpranke@ PTAL Also presubmit failed on https://codereview.chromium.org/2463523002/ Not sure if I have to land the ...
4 years, 1 month ago (2016-10-31 19:02:22 UTC) #1
Dirk Pranke
lgtm w/ comments addressed. https://codereview.chromium.org/2470453002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2470453002/diff/1/tools/mb/mb_config.pyl#newcode1329 tools/mb/mb_config.pyl:1329: 'ozone_x11', 'enable_mash_services', 'disable_ash', Generally I ...
4 years, 1 month ago (2016-10-31 19:58:20 UTC) #2
Tom (Use chromium acct)
https://codereview.chromium.org/2470453002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2470453002/diff/1/tools/mb/mb_config.pyl#newcode1329 tools/mb/mb_config.pyl:1329: 'ozone_x11', 'enable_mash_services', 'disable_ash', On 2016/10/31 19:58:20, Dirk Pranke wrote: ...
4 years, 1 month ago (2016-10-31 23:20:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470453002/20001
4 years, 1 month ago (2016-10-31 23:21:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/98045)
4 years, 1 month ago (2016-10-31 23:35:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470453002/20001
4 years, 1 month ago (2016-11-01 01:49:41 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-01 02:04:46 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a4772dcd8400da7137c37e9590acdadba1306783 Cr-Commit-Position: refs/heads/master@{#428912}
4 years, 1 month ago (2016-11-01 02:06:43 UTC) #13
tonikitoo
4 years, 1 month ago (2016-11-01 13:10:11 UTC) #14
Message was sent while issue was closed.
On 2016/10/31 19:02:22, Tom Anderson wrote:
> dpranke@ PTAL
> 
> Also presubmit failed on
> https://codereview.chromium.org/2463523002/
> 
> Not sure if I have to land the src-side changes first?

Thanks!

I believe for the source side changes, we still need
https://codereview.chromium.org/2408803002/ merged first?

BTW, I am in the process of splitting it up into smaller pieces, to reduce the
review burden: 

https://codereview.chromium.org/2454743002/ (merged)
https://codereview.chromium.org/2457443004/ (merged)
https://codereview.chromium.org/2452063002/ (merged)
https://codereview.chromium.org/2449103004/ (under review)
... more ...

I should upload a newer version of the CL today.

Powered by Google App Engine
This is Rietveld 408576698