Chromium Code Reviews
Help | Chromium Project | Sign in
(6)

Issue 2454743002: Only call X11DesktopHandler for USE_X11 builds (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months ago by tonikitoo
Modified:
5 months ago
CC:
chromium-reviews, tfarina, fwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only call X11DesktopHandler for USE_X11 builds ... and the same applies to calling ui::GetCustomFramePrefDefault, implemented in ui/base/x/x11_util.cc BUG=295089 Committed: https://crrev.com/f2f307b06528f971698a6e729a89bd74d6a06b23 Cr-Commit-Position: refs/heads/master@{#427830}

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressed sadrul's suggestion #

Messages

Total messages: 28 (16 generated)
tonikitoo
PTAL
5 months ago (2016-10-26 14:54:44 UTC) #3
fwang
This seems to be the right thing to do to avoid compiling X11 stuff. informal ...
5 months ago (2016-10-26 15:12:23 UTC) #6
sadrul
https://codereview.chromium.org/2454743002/diff/1/chrome/browser/ui/browser_view_prefs.cc File chrome/browser/ui/browser_view_prefs.cc (right): https://codereview.chromium.org/2454743002/diff/1/chrome/browser/ui/browser_view_prefs.cc#newcode35 chrome/browser/ui/browser_view_prefs.cc:35: #if defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(USE_X11) I would remove ...
5 months ago (2016-10-26 16:39:47 UTC) #10
tonikitoo
https://codereview.chromium.org/2454743002/diff/1/chrome/browser/ui/browser_view_prefs.cc File chrome/browser/ui/browser_view_prefs.cc (right): https://codereview.chromium.org/2454743002/diff/1/chrome/browser/ui/browser_view_prefs.cc#newcode35 chrome/browser/ui/browser_view_prefs.cc:35: #if defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(USE_X11) On 2016/10/26 16:39:47, ...
5 months ago (2016-10-26 16:47:24 UTC) #11
Lei Zhang
lgtm with sadrul's approval.
5 months ago (2016-10-26 17:07:36 UTC) #12
Tom Anderson
lgtm
5 months ago (2016-10-26 17:37:16 UTC) #14
sadrul
lgtm
5 months ago (2016-10-26 17:48:57 UTC) #15
rjkroege
lgtm fwiw.
5 months ago (2016-10-26 18:47:06 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454743002/20001
5 months ago (2016-10-26 19:37:31 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 months ago (2016-10-26 21:54:16 UTC) #24
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f2f307b06528f971698a6e729a89bd74d6a06b23 Cr-Commit-Position: refs/heads/master@{#427830}
5 months ago (2016-10-26 21:57:32 UTC) #26
fwang
5 months ago (2016-10-27 17:01:18 UTC) #28
Message was sent while issue was closed.

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d1a128a62