Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(14)

Issue 2457443004: Build some x11 dependent files only if 'use_x11' (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 months ago by tonikitoo
Modified:
8 months ago
CC:
chromium-reviews, fwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Build some x11 dependent files only if 'use_x11' This will make it easier to make desktop linux chrome builds, through Ozone. BUG=295089 Committed: https://crrev.com/8e861c0932dc392508ab64284ce160d1a58c700e Cr-Commit-Position: refs/heads/master@{#428174}

Patch Set 1 #

Patch Set 2 : Build some x11 dependent files if 'use_x11' #

Total comments: 1

Patch Set 3 : Build some x11 dependent files if 'use_x11' #

Total comments: 2

Patch Set 4 : Build some x11 dependent files if 'use_x11' #

Patch Set 5 : Build some x11 dependent files if 'use_x11' #

Patch Set 6 : Build some x11 dependent files if 'use_x11' #

Messages

Total messages: 29 (19 generated)
not to use - tonikitoo
PTAL
8 months ago (2016-10-27 16:56:28 UTC) #12
Lei Zhang
Can you check the unit tests for the files in the use_x11 block, if any, ...
8 months ago (2016-10-27 17:00:16 UTC) #13
tonikitoo
On 2016/10/27 17:00:16, Lei Zhang wrote: > Can you check the unit tests for the ...
8 months ago (2016-10-27 18:11:38 UTC) #14
fwang
informal l g t m https://codereview.chromium.org/2457443004/diff/40001/chrome/browser/BUILD.gn File chrome/browser/BUILD.gn (right): https://codereview.chromium.org/2457443004/diff/40001/chrome/browser/BUILD.gn#newcode3511 chrome/browser/BUILD.gn:3511: # is conditioned by ...
8 months ago (2016-10-27 18:19:16 UTC) #16
tonikitoo
https://codereview.chromium.org/2457443004/diff/40001/chrome/browser/BUILD.gn File chrome/browser/BUILD.gn (right): https://codereview.chromium.org/2457443004/diff/40001/chrome/browser/BUILD.gn#newcode3511 chrome/browser/BUILD.gn:3511: # is conditioned by USE_X11. On 2016/10/27 18:19:16, fwang ...
8 months ago (2016-10-27 18:28:41 UTC) #17
Lei Zhang
On 2016/10/27 18:11:38, tonikitoo wrote: > "bleh_x.cc/h" indicating unix/non-mac isn't too clear, but it makes ...
8 months ago (2016-10-27 21:04:39 UTC) #20
Lei Zhang
lgtm
8 months ago (2016-10-27 21:09:46 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2457443004/90001
8 months ago (2016-10-27 22:06:37 UTC) #25
commit-bot: I haz the power
Committed patchset #6 (id:90001)
8 months ago (2016-10-27 22:49:09 UTC) #27
commit-bot: I haz the power
8 months ago (2016-10-27 22:52:26 UTC) #29
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/8e861c0932dc392508ab64284ce160d1a58c700e
Cr-Commit-Position: refs/heads/master@{#428174}
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cb946e318