|
|
Chromium Code Reviews|
Created:
4 years, 1 month ago by Tom (Use chromium acct) Modified:
4 years, 1 month ago Reviewers:
Dirk Pranke CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd Linux Ozone fyi compile-only bot (src-side changes)
BUG=295089
R=dpranke@chromium.org
Committed: https://crrev.com/a4772dcd8400da7137c37e9590acdadba1306783
Cr-Commit-Position: refs/heads/master@{#428912}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Formatting #Messages
Total messages: 14 (5 generated)
dpranke@ PTAL Also presubmit failed on https://codereview.chromium.org/2463523002/ Not sure if I have to land the src-side changes first?
lgtm w/ comments addressed. https://codereview.chromium.org/2470453002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2470453002/diff/1/tools/mb/mb_config.pyl#newc... tools/mb/mb_config.pyl:1329: 'ozone_x11', 'enable_mash_services', 'disable_ash', Generally I like for the config name to be the result of '_'.join(mixins). That, plus the fact that you're adding a bunch of args that are only needed in one config, suggests that this should be: 'release_bot_ozone_linux': ['release_bot', 'ozone_linux'] ... 'ozone_linux': { 'mixins': ['ozone'], 'gn_args': 'ozone_auto_platforms=false ozone_platform_wayland=true ...', }
https://codereview.chromium.org/2470453002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2470453002/diff/1/tools/mb/mb_config.pyl#newc... tools/mb/mb_config.pyl:1329: 'ozone_x11', 'enable_mash_services', 'disable_ash', On 2016/10/31 19:58:20, Dirk Pranke wrote: > Generally I like for the config name to be the result of '_'.join(mixins). That, > plus the fact that you're adding a bunch of args that are only needed in one > config, suggests that this should be: > > 'release_bot_ozone_linux': ['release_bot', 'ozone_linux'] > > ... > > 'ozone_linux': { > 'mixins': ['ozone'], > 'gn_args': 'ozone_auto_platforms=false ozone_platform_wayland=true ...', > } > Done.
The CQ bit was checked by thomasanderson@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2470453002/#ps20001 (title: "Formatting")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by thomasanderson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add Linux Ozone fyi compile-only bot (src-side changes) BUG=295089 R=dpranke@chromium.org ========== to ========== Add Linux Ozone fyi compile-only bot (src-side changes) BUG=295089 R=dpranke@chromium.org Committed: https://crrev.com/a4772dcd8400da7137c37e9590acdadba1306783 Cr-Commit-Position: refs/heads/master@{#428912} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/a4772dcd8400da7137c37e9590acdadba1306783 Cr-Commit-Position: refs/heads/master@{#428912}
Message was sent while issue was closed.
On 2016/10/31 19:02:22, Tom Anderson wrote: > dpranke@ PTAL > > Also presubmit failed on > https://codereview.chromium.org/2463523002/ > > Not sure if I have to land the src-side changes first? Thanks! I believe for the source side changes, we still need https://codereview.chromium.org/2408803002/ merged first? BTW, I am in the process of splitting it up into smaller pieces, to reduce the review burden: https://codereview.chromium.org/2454743002/ (merged) https://codereview.chromium.org/2457443004/ (merged) https://codereview.chromium.org/2452063002/ (merged) https://codereview.chromium.org/2449103004/ (under review) ... more ... I should upload a newer version of the CL today. |
